From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6795 invoked by alias); 1 Jul 2010 10:41:33 -0000 Received: (qmail 6782 invoked by uid 22791); 1 Jul 2010 10:41:32 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Jul 2010 10:41:28 +0000 Received: (qmail 22899 invoked from network); 1 Jul 2010 10:41:26 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Jul 2010 10:41:26 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: Static tracepoints support Date: Thu, 01 Jul 2010 10:41:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.31-10-rt; KDE/4.4.2; x86_64; ; ) References: <201006251931.57860.pedro@codesourcery.com> <201006292159.49527.pedro@codesourcery.com> <8339w4bd3q.fsf@gnu.org> In-Reply-To: <8339w4bd3q.fsf@gnu.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201007011141.23018.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00001.txt.bz2 On Wednesday 30 June 2010 19:16:09, Eli Zaretskii wrote: > > From: Pedro Alves > > Here's a new version of the patch integrating all of the > > above. Any further comments? > > Just three: > > > + $_sdata internal variable. When analying the trace buffer, you can > ^^^^^^^^ > A typo (sorry I didn't catch that before). > > > +Whether the breakpoint is marked to be disabled or deleted when hit. > > Wasn't there supposed to be an @item before this sentence? Arrh, copy&paste from "info breakpoints".. the sentence wasn't even supposed to be there, I've removed it (it's describing breakpoint's dispositions). > > > +UST backend, this is the the format string passed as argument to the > ^^^ > Redundant "the". > > Okay with those changes. Checked in with those changes. Thank you for the review! -- Pedro Alves