From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: Static tracepoints support
Date: Thu, 01 Jul 2010 17:13:00 -0000 [thread overview]
Message-ID: <201007011813.02237.pedro@codesourcery.com> (raw)
In-Reply-To: <83pqz79lhg.fsf@gnu.org>
On Thursday 01 July 2010 18:10:19, Eli Zaretskii wrote:
> > From: Pedro Alves <pedro@codesourcery.com>
> > Date: Thu, 1 Jul 2010 15:00:26 +0100
> > Cc: Eli Zaretskii <eliz@gnu.org>
> >
> > On Monday 28 June 2010 13:26:38, Pedro Alves wrote:
> > > > > +with that name. With no LOCATION, uses current execution address of \n\
> > > > > +selected stack frame.\n\
> > > >
> > > > "of the selected stack frame"
> > >
> > > Fixed. Needs fixing in BREAK_ARGS_HELP; it's showing up in the help
> > > strings of all breakpoint commands.
> > >
> >
> > Here's the fix for all other breakpoint commands, but I do
> > note some sort of pattern here: it appears that "the" was
> > avoided on purpose in all the sentences as can be seen in
> > the contenxt of the patch. Would you like to review
> > the whole help string, or is this correct?
>
> "the selected stack frame" is correct here.
Okay, though I was more trying to suggest to check if the other
"the"'s are actually missing, like "With no LOCATION, uses _the_
current execution address of _the_ selected frame", and "break at
_the_ start of code for that function".
I'll apply the patch once I adjust the testsuite
accordinly (help.exp).
--
Pedro Alves
next prev parent reply other threads:[~2010-07-01 17:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 18:33 Pedro Alves
2010-06-26 10:34 ` Eli Zaretskii
2010-06-28 12:28 ` Pedro Alves
2010-06-28 20:03 ` Eli Zaretskii
2010-06-29 21:00 ` Pedro Alves
2010-06-30 18:14 ` Eli Zaretskii
2010-07-01 10:41 ` Pedro Alves
2010-07-01 14:22 ` clarify "help break" output a bit (Re: Static tracepoints support) Pedro Alves
2010-07-01 17:10 ` Eli Zaretskii
2010-06-28 20:04 ` Static tracepoints support Eli Zaretskii
2010-07-01 13:50 ` el vs ell (Re: Static tracepoints support) Pedro Alves
2010-07-01 16:26 ` Michael Snyder
2010-07-01 17:07 ` Eli Zaretskii
2010-07-01 17:28 ` Pedro Alves
2010-07-01 14:00 ` Static tracepoints support Pedro Alves
2010-07-01 17:08 ` Eli Zaretskii
2010-07-01 17:13 ` Pedro Alves [this message]
2010-07-01 14:15 ` add a few index entries (Re: Static tracepoints support) Pedro Alves
2010-07-01 17:09 ` Eli Zaretskii
2010-07-01 15:38 ` remove redundant blank from strings " Pedro Alves
2010-07-01 17:11 ` Eli Zaretskii
2010-07-01 16:36 ` dynamic type column width in "info breakpoints" output " Pedro Alves
2010-07-01 17:17 ` Eli Zaretskii
2010-07-02 21:35 ` Tom Tromey
2010-07-21 11:30 ` Pedro Alves
2010-06-27 22:47 ` Static tracepoints support Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007011813.02237.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).