From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1738 invoked by alias); 7 Jul 2010 16:45:09 -0000 Received: (qmail 1728 invoked by uid 22791); 7 Jul 2010 16:45:07 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Jul 2010 16:45:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BAD8A2BAB29; Wed, 7 Jul 2010 12:44:59 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id QrW-YrSk1Bir; Wed, 7 Jul 2010 12:44:59 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D29ED2BAB05; Wed, 7 Jul 2010 12:44:58 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 42822F5895; Wed, 7 Jul 2010 09:44:42 -0700 (PDT) Date: Wed, 07 Jul 2010 16:45:00 -0000 From: Joel Brobecker To: Thiago Jung Bauermann Cc: Ulrich Weigand , gdb-patches@sourceware.org, Luis Machado , Matt Tyrlik Subject: Re: [PATCH 2/4] Hardware accelerated watchpoint conditions Message-ID: <20100707164442.GJ2595@adacore.com> References: <201007071224.o67COtto014736@d12av02.megacenter.de.ibm.com> <1278519651.2544.10.camel@hactar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1278519651.2544.10.camel@hactar> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00115.txt.bz2 > > > 2010-07-06 Sergio Durigan Junior > > > Thiago Jung Bauermann > > > > > > * breakpoint.c (fetch_watchpoint_value): Rename to fetch_subexp_value > > > and move to eval.c. Change callers. > > > (insert_bp_location): Pass watchpoint condition in > > > target_insert_watchpoint. > > > (remove_breakpoint_1) Pass watchpoint condition in > > > target_remove_watchpoint. > > > (watchpoint_locations_match): Call > > > target_can_accel_watchpoint_condition. > > > * eval.c: Include wrapper.h. > > > (fetch_subexp_value): Moved from breakpoint.c. > > > * ppc-linux-nat.c (ppc_linux_region_ok_for_hw_watchpoint): > > > Formatting fix. > > > (can_use_watchpoint_cond_accel): New function. > > > (calculate_dvc): Likewise. > > > (num_memory_accesses): Likewise. > > > (check_condition): Likewise. > > > (ppc_linux_can_accel_watchpoint_condition): Likewise > > > (ppc_linux_insert_watchpoint): Call can_use_watchpoint_cond_accel, > > > check_condition and calculate_dvc. > > > (ppc_linux_remove_watchpoint): Likewise. > > > (_initialize_ppc_linux_nat): Set to_can_accel_watchpoint_condition to > > > ppc_linux_can_accel_watchpoint_condition > > > * target.c (debug_to_insert_watchpoint): Add argument for watchpoint > > > condition. > > > (debug_to_remove_watchpoint): Likewise. > > > (debug_to_can_accel_watchpoint_condition): New function. > > > (update_current_target): Set to_can_accel_watchpoint_condition. > > > (setup_target_debug): Set to_can_accel_watchpoint_condition. > > > * target.h: Add opaque declaration for struct expression. > > > (struct target_ops) , > > > : Add new arguments to pass the watchpoint > > > : New member. > > > condition. Update all callers and implementations. > > > (target_can_accel_watchpoint_condition): New macro. > > > * value.c (free_value_chain): New function. > > > * value.h (fetch_subexp_value): New prototype. > > > (free_value_chain): Likewise. > > > > This is OK. > > Committed, thanks! I am a little nervous about including this in 7.2 given that it changes the interface of target_ops functions. But at the same time, it's been WIP for so long that I feel that everyone who contributed to getting this piece of code in deserves to see this code in 7.2. We can work out any missing API updates, if any during the branch stabilization phase. Any objection, please yell. -- Joel