From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: hjl.tools@gmail.com (H.J. Lu)
Cc: mark.kettenis@xs4all.nl (Mark Kettenis),
jan.kratochvil@redhat.com, Jon.Zhou@jdsu.com,
gdb-patches@sourceware.org
Subject: Re: [rfc] skip_ilp32_tests / skip_lp64_tests predicates (was: Re: support biarch gcore?)
Date: Mon, 12 Jul 2010 14:49:00 -0000 [thread overview]
Message-ID: <201007121448.o6CEmZMS025235@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <AANLkTimgxYoUY6gAOps39NdPv53YCeOk2kXBq87qVriG@mail.gmail.com> from "H.J. Lu" at Jul 09, 2010 03:33:22 PM
H.J. Lu wrote:
> > This syntax is strange. There are
> >
> > --
> > if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } {
> > verbose "Skipping x86 AVX tests."
> > return
> > }
> > ...
> > if [istarget i?86-*-*] {
> > set nr_regs 8
> > } else {
> > set nr_regs 16
> > }
> > ...
> >
> > I am looking for something like is_ilp32/is_lp64.
Hmm, I was simply trying to keep the naming scheme in line with
the pre-existing skip_..._tests routines. However, I guess you're
right if the test needs to be used for other decisions than
simply skipping a test, a different name would be better.
> 2010-07-09 Ulrich Weigand <uweigand@de.ibm.com>
> H.J. Lu <hongjiu.lu@intel.com>
>
> * lib/gdb.exp (is_ilp32_target): New.
> (is_lp64_target): Likewise.
>
> * gdb.arch/amd64-byte.exp: Use is_lp64_target to check 64bit
> target.
> * gdb.arch/amd64-disp-step.exp: Likewise.
> * gdb.arch/amd64-dword.exp: Likewise.
> * gdb.arch/amd64-i386-address.exp: Likewise.
> * gdb.arch/amd64-word.exp: Likewise.
>
> * gdb.arch/i386-avx.exp: Use is_ilp32_target to check for 32bit
> target.
> * gdb.arch/i386-bp_permanent.exp: Likewise.
> * gdb.arch/i386-byte.exp: Likewise.
> * gdb.arch/i386-disp-step.exp: Likewise.
> * gdb.arch/i386-gnu-cfi.exp: Likewise.
> * gdb.arch/i386-prologue.exp: Likewise.
> * gdb.arch/i386-size-overlap.exp: Likewise.
> * gdb.arch/i386-size.exp: Likewise.
> * gdb.arch/i386-sse.exp: Likewise.
> * gdb.arch/i386-unwind.exp: Likewise.
> * gdb.arch/i386-word.exp: Likewise.
>
> * gdb.arch/ppc64-atomic-inst.exp: Use is_lp64_target to execute
> test only when building 64-bit executables. Do not hard-code
> -m64 option.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2010-07-12 14:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201007062128.o66LSkNC032580@glazunov.sibelius.xs4all.nl>
2010-07-07 12:30 ` support biarch gcore? Ulrich Weigand
2010-07-08 2:35 ` Jon Zhou
2010-07-08 11:17 ` Ulrich Weigand
2010-07-08 4:47 ` H.J. Lu
2010-07-08 5:05 ` H.J. Lu
2010-07-08 11:15 ` Ulrich Weigand
2010-07-08 13:52 ` H.J. Lu
2010-07-09 15:48 ` [rfc] skip_ilp32_tests / skip_lp64_tests predicates (was: Re: support biarch gcore?) Ulrich Weigand
2010-07-09 15:56 ` H.J. Lu
2010-07-09 21:43 ` H.J. Lu
2010-07-09 22:33 ` H.J. Lu
2010-07-12 14:49 ` Ulrich Weigand [this message]
2010-07-21 22:45 ` support biarch gcore? Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007121448.o6CEmZMS025235@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=Jon.Zhou@jdsu.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=jan.kratochvil@redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).