From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27293 invoked by alias); 12 Jul 2010 14:49:11 -0000 Received: (qmail 27281 invoked by uid 22791); 12 Jul 2010 14:49:10 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.17.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Jul 2010 14:48:40 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.1/8.13.1) with ESMTP id o6CEmbH2022291 for ; Mon, 12 Jul 2010 14:48:37 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o6CEmaHB1700088 for ; Mon, 12 Jul 2010 16:48:36 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o6CEmao1025267 for ; Mon, 12 Jul 2010 16:48:36 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o6CEmZMS025235; Mon, 12 Jul 2010 16:48:35 +0200 Message-Id: <201007121448.o6CEmZMS025235@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 12 Jul 2010 16:48:34 +0200 Subject: Re: [rfc] skip_ilp32_tests / skip_lp64_tests predicates (was: Re: support biarch gcore?) To: hjl.tools@gmail.com (H.J. Lu) Date: Mon, 12 Jul 2010 14:49:00 -0000 From: "Ulrich Weigand" Cc: mark.kettenis@xs4all.nl (Mark Kettenis), jan.kratochvil@redhat.com, Jon.Zhou@jdsu.com, gdb-patches@sourceware.org In-Reply-To: from "H.J. Lu" at Jul 09, 2010 03:33:22 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00204.txt.bz2 H.J. Lu wrote: > > This syntax is strange. There are > > > > -- > > if { ![istarget i?86-*-*] && ![istarget x86_64-*-* ] } { > > verbose "Skipping x86 AVX tests." > > return > > } > > ... > > if [istarget i?86-*-*] { > > set nr_regs 8 > > } else { > > set nr_regs 16 > > } > > ... > > > > I am looking for something like is_ilp32/is_lp64. Hmm, I was simply trying to keep the naming scheme in line with the pre-existing skip_..._tests routines. However, I guess you're right if the test needs to be used for other decisions than simply skipping a test, a different name would be better. > 2010-07-09 Ulrich Weigand > H.J. Lu > > * lib/gdb.exp (is_ilp32_target): New. > (is_lp64_target): Likewise. > > * gdb.arch/amd64-byte.exp: Use is_lp64_target to check 64bit > target. > * gdb.arch/amd64-disp-step.exp: Likewise. > * gdb.arch/amd64-dword.exp: Likewise. > * gdb.arch/amd64-i386-address.exp: Likewise. > * gdb.arch/amd64-word.exp: Likewise. > > * gdb.arch/i386-avx.exp: Use is_ilp32_target to check for 32bit > target. > * gdb.arch/i386-bp_permanent.exp: Likewise. > * gdb.arch/i386-byte.exp: Likewise. > * gdb.arch/i386-disp-step.exp: Likewise. > * gdb.arch/i386-gnu-cfi.exp: Likewise. > * gdb.arch/i386-prologue.exp: Likewise. > * gdb.arch/i386-size-overlap.exp: Likewise. > * gdb.arch/i386-size.exp: Likewise. > * gdb.arch/i386-sse.exp: Likewise. > * gdb.arch/i386-unwind.exp: Likewise. > * gdb.arch/i386-word.exp: Likewise. > > * gdb.arch/ppc64-atomic-inst.exp: Use is_lp64_target to execute > test only when building 64-bit executables. Do not hard-code > -m64 option. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com