From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31296 invoked by alias); 12 Jul 2010 14:55:48 -0000 Received: (qmail 31279 invoked by uid 22791); 12 Jul 2010 14:55:47 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.17.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Jul 2010 14:55:41 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.1/8.13.1) with ESMTP id o6CEtc6U030007 for ; Mon, 12 Jul 2010 14:55:38 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o6CEtc2M1511560 for ; Mon, 12 Jul 2010 16:55:38 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o6CEtblO009753 for ; Mon, 12 Jul 2010 16:55:37 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o6CEtale009687; Mon, 12 Jul 2010 16:55:36 +0200 Message-Id: <201007121455.o6CEtale009687@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 12 Jul 2010 16:55:36 +0200 Subject: Re: [patch] Small fix for assigning values to vectors To: ken@linux.vnet.ibm.com (Ken Werner) Date: Mon, 12 Jul 2010 14:55:00 -0000 From: "Ulrich Weigand" Cc: dan@codesourcery.com (Daniel Jacobowitz), Ulrich.Weigand@de.ibm.com (Ulrich Weigand), gdb-patches@sourceware.org In-Reply-To: <201007101905.07082.ken@linux.vnet.ibm.com> from "Ken Werner" at Jul 10, 2010 07:05:06 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00205.txt.bz2 Ken Werner wrote: > On Saturday, July 10, 2010 05:39:09 pm Daniel Jacobowitz wrote: > > On Sat, Jul 10, 2010 at 03:03:53PM +0200, Ken Werner wrote: > > > But while we are at it. Are there any objections on copying the contents > > > to the destination instead of creating a pointer? > > > > I think we're going a bit too far now, and maybe we need to figure out > > what the semantics of internalvars are supposed to be... > > > > With this, IIUC, "set $internalvar = program_array" is going to read > > the whole array. Previously, it would decay to a pointer as in C. > > I agree. As I don't have a strong opinion either way on this particular case > I'd leave that decision to more experienced GDB developers. Yes, this is a separate issue; let's leave the behaviour as is for now. > Here is the patch I intended to post where only the call to > value_coerce_to_target is omitted and the value_must_coerce_to_target routine > returns zero in case of a vector. Tested on powerpc64-*-linux-gnu with no > regressions. > Changelog: > > 2010-07-09 Ken Werner > > * valops.c (value_assign): Do not call to value_coerce_to_target. > (value_must_coerce_to_target): Return 0 in case of TYPE_VECTOR. > > testsuite/ChangeLog: > > 2010-07-09 Ken Werner > > * gdb.arch/altivec-abi.exp: New tests. This is OK. I think you should get Write After Approval access to the GDB CVS so that you can commit your approved patches yourself. Please apply using this form: http://sourceware.org/cgi-bin/pdw/ps_form.cgi Once you get access, please add yourself to the MAINTAINERS file under the Write After Approval section, and then commit your patch. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com