From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Cc: Ozkan Sezer <sezeroz@gmail.com>, Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH] [Windows] fix format string for 64 bit var in gdbserver
Date: Sat, 17 Jul 2010 09:40:00 -0000 [thread overview]
Message-ID: <201007170537.44785.vapier@gentoo.org> (raw)
In-Reply-To: <AANLkTilqLsYAUtXVYK-DL-uDFyKVbsxEz2CmJyJoese7@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 861 bytes --]
On Friday, July 16, 2010 16:10:23 Ozkan Sezer wrote:
> For windows targets, (x86_64-w64-mingw32, i686-w64-mingw32)
> gcc complains:
>
> ../../../gdb-cvs/gdb/gdbserver/server.c: In function 'handle_query':
> ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: unknown
> conversion type character 'l' in format
> ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: too many
> arguments for format
> ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: unknown
> conversion type character 'l' in format
> ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: too many
> arguments for format
>
> This is due to the fact that MS printf doesn't support %lld, it uses
> its own %I64d which gcc already knows about. The attached patch
> changes that. OK for apply?
ugh, no. why not use a sane define like PRIx64 from inttypes.h ?
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-07-17 9:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-16 20:10 Ozkan Sezer
2010-07-17 9:40 ` Mike Frysinger [this message]
2010-07-17 9:42 ` Ozkan Sezer
2010-07-17 9:53 ` Ozkan Sezer
2010-07-17 18:50 ` Mike Frysinger
2010-07-17 18:59 ` Ozkan Sezer
2010-07-17 19:19 ` Mike Frysinger
2010-07-17 19:23 ` Ozkan Sezer
2010-07-17 21:01 ` Andreas Schwab
2010-07-17 21:05 ` Ozkan Sezer
2010-07-20 18:20 ` Ozkan Sezer
2010-07-17 12:29 ` Mark Kettenis
2010-07-17 18:49 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007170537.44785.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=sezeroz@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).