From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30807 invoked by alias); 17 Jul 2010 09:40:44 -0000 Received: (qmail 30791 invoked by uid 22791); 17 Jul 2010 09:40:43 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Jul 2010 09:40:38 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id F3AD91B4052; Sat, 17 Jul 2010 09:40:36 +0000 (UTC) From: Mike Frysinger To: gdb-patches@sourceware.org Subject: Re: [PATCH] [Windows] fix format string for 64 bit var in gdbserver Date: Sat, 17 Jul 2010 09:40:00 -0000 User-Agent: KMail/1.13.1 (Linux/2.6.34; KDE/4.4.4; x86_64; ; ) Cc: Ozkan Sezer , Tom Tromey References: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5137546.lXNQMX0AHK"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201007170537.44785.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00257.txt.bz2 --nextPart5137546.lXNQMX0AHK Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-length: 845 On Friday, July 16, 2010 16:10:23 Ozkan Sezer wrote: > For windows targets, (x86_64-w64-mingw32, i686-w64-mingw32) > gcc complains: >=20 > ../../../gdb-cvs/gdb/gdbserver/server.c: In function 'handle_query': > ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: unknown > conversion type character 'l' in format > ../../../gdb-cvs/gdb/gdbserver/server.c:1542: warning: too many > arguments for format > ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: unknown > conversion type character 'l' in format > ../../../gdb-cvs/gdb/gdbserver/server.c:1566: warning: too many > arguments for format >=20 > This is due to the fact that MS printf doesn't support %lld, it uses > its own %I64d which gcc already knows about. The attached patch > changes that. OK for apply? ugh, no. why not use a sane define like PRIx64 from inttypes.h ? -mike --nextPart5137546.lXNQMX0AHK Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) iQIcBAABAgAGBQJMQXnoAAoJEEFjO5/oN/WBilsP/jWITqvO6N+J+ubH37Kru2GX NZqksicITEbldRH8kjyrnT6hO+H7s1lTDcok3I3rxqoCqHwsfRe07rh55cKYVrCE o79GbDFScdUdW7XGoSrG/PeJE2DTaaeYQ85X93P4dpF/zNAJnsHuIEb10Wl564xF PmCDUMe6YLT1qVKN0rS3oQBCfLY5v3soofWpdvki1lKYkTE9oDUzzaysLYF4gi8d PlFM7sNzkW1x87g30eq8sfngwT7etEh/vkzWEdw6NxWEisU1AP0vro0Kg2m3o6Zq HJV6rrHImqnEytBematxniORrciq1ABfo8viCs3LDvaC1+QoZMJPRqaPRPiLsX0m +v7mncOft/fJBPl7Z9lfjrKd3h7aetQKvUGPOqpRqgXW8eqw4ty37Ix7THzDpvsd DJZbBOJeRCBFtoy01LFMPLDH+z+uFViGpeberdKiNoHmlGO5mUTITKsz8BCMis56 5U2pvxLPzzN0IFdVvUhTR/0q8TDcaTO1opK3HFRCr5Rm6F8q9JpLBFojeiF931BS BNY2u4XT+c2NWHviepnr1C3v9aeool+JUC4+9iVOF2zuiuBBQL/WSxdGupRLE6G6 ha1yKJmS3pKJL5qgCBW82hbHvPqukkSGN5kZ8PBfcfZ0X74i87rTJZX/2T5F/XAh /3sqaf/Ic7meDHrW9OaJ =sUc9 -----END PGP SIGNATURE----- --nextPart5137546.lXNQMX0AHK--