From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74403-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16852 invoked by alias); 20 Jul 2010 12:22:38 -0000
Received: (qmail 16839 invoked by uid 22791); 20 Jul 2010 12:22:38 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Jul 2010 12:22:34 +0000
Received: (qmail 12016 invoked from network); 20 Jul 2010 12:22:32 -0000
Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 20 Jul 2010 12:22:32 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] Fix linux-nat.c {,lp->}status typo
Date: Tue, 20 Jul 2010 12:22:00 -0000
User-Agent: KMail/1.13.2 (Linux/2.6.31-11-rt; KDE/4.4.2; x86_64; ; )
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
References: <20100718145110.GA16697@host1.dyn.jankratochvil.net>
In-Reply-To: <20100718145110.GA16697@host1.dyn.jankratochvil.net>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201007201322.28556.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00294.txt.bz2

On Sunday 18 July 2010 15:51:12, Jan Kratochvil wrote:

> while reading the code I found this suspicious code, IMO a typo.
> 
>               if (WIFSTOPPED (lp->status))
>                 {
>                   if (WSTOPSIG (lp->status) != SIGSTOP)
> 		  [...]
>                 }
>               else if (WIFEXITED (status) || WIFSIGNALED (status))
> 	      [...]
> 

> No regressions on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu.
> (I haven't tried to find an impact of this bug.)

In practice, status == lp->status at this point for !WIFSTOPPED,
so there should be no impact.

> 2010-07-18  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* linux-nat.c (linux_nat_wait_1): Reset STATUS after calling
> 	linux_nat_wait_1.  Use always LP->STATUS afterwards.

Okay, thanks.

-- 
Pedro Alves