From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] Fix internal error on library without dirname
Date: Tue, 20 Jul 2010 21:45:00 -0000 [thread overview]
Message-ID: <20100720214451.GA28276@host1.dyn.jankratochvil.net> (raw)
Hi,
in some special cases ld.so can provide library name without any slash (/).
Starting program: [...]
../../gdb/symfile.c:1326: internal-error: find_separate_debug_file_by_debuglink: Assertion `i >= 0 && IS_DIR_SEPARATOR (dir[i])' failed.
A problem internal to GDB has been detected,
No regressions on {x86_64,x86_64-m32,i686}-fedora13-linux-gnu.
I believe it could go for 7.2.
I tried to step through find_separate_debug_file_by_debuglink in this case and
the code seems OK with DIR eq "".
Thanks,
Jan
gdb/
2010-07-20 Jan Kratochvil <jan.kratochvil@redhat.com>
* symfile.c (find_separate_debug_file_by_debuglink): Remove
a gdb_assert call, new comment.
gdb/testsuite/
2010-07-20 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.base/solib-nodir.exp: New file.
* lib/gdb.exp (runto): New case for a GDB internal error.
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -1382,7 +1382,7 @@ find_separate_debug_file_by_debuglink (struct objfile *objfile)
if (IS_DIR_SEPARATOR (dir[i]))
break;
}
- gdb_assert (i >= 0 && IS_DIR_SEPARATOR (dir[i]));
+ /* If I is -1 then no directory is present there and DIR will be "". */
dir[i+1] = '\0';
/* Set I to max (strlen (canon_name), strlen (dir)). */
--- /dev/null
+++ b/gdb/testsuite/gdb.base/solib-nodir.exp
@@ -0,0 +1,54 @@
+# Copyright 2010 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+# are we on a target board
+if {![isnative] || [skip_shlib_tests]} {
+ return
+}
+
+set testfile "solib-nodir"
+# Arbitrary file, possibly not containing main, even an empty one.
+set srclibfile foo.c
+# Arbitrary file containing main.
+set srcfile start.c
+set binlibfilebase ${testfile}.so
+set binlibfiledir ${objdir}/${subdir}
+set binlibfile ${binlibfiledir}/${binlibfilebase}
+set executable ${testfile}
+set objfile ${objdir}/${subdir}/${executable}.o
+set binfile ${objdir}/${subdir}/${executable}
+
+# build the first test case
+if { [get_compiler_info unused]
+ || [gdb_compile_shlib "${srcdir}/${subdir}/${srclibfile}" "${binlibfile}" [list debug additional_flags=-Wl,-soname,${binlibfilebase}]] != ""
+ || [gdb_gnu_strip_debug $binlibfile]
+ || [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${objfile}" object {debug}] != ""
+ || [gdb_compile "${objfile} ${binlibfile}" "${binfile}" executable {}] != "" } {
+ untested ${testfile}.exp
+ return -1
+}
+
+clean_restart $executable
+gdb_load_shlibs ${binlibfile}
+
+gdb_test_no_output "set env LD_LIBRARY_PATH=:"
+gdb_test "cd ${binlibfiledir}" "Working directory [string_to_regexp ${binlibfiledir}]\\."
+
+set test "library loaded"
+if [runto_main] {
+ pass $test
+} else {
+ fail $test
+}
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -423,6 +423,11 @@ proc runto { function args } {
unsupported "Non-stop mode not supported"
return 0
}
+ -re ".*A problem internal to GDB has been detected" {
+ fail "running to $function in runto (GDB internal error)"
+ gdb_internal_error_resync
+ return 0
+ }
-re "$gdb_prompt $" {
fail "running to $function in runto"
return 0
next reply other threads:[~2010-07-20 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 21:45 Jan Kratochvil [this message]
2010-07-20 22:03 ` Tom Tromey
2010-07-20 22:24 ` Jan Kratochvil
2010-07-20 22:47 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720214451.GA28276@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).