From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [patch] save gdb-index user interface fixups
Date: Thu, 22 Jul 2010 09:46:00 -0000 [thread overview]
Message-ID: <20100722094637.GA16205@host1.dyn.jankratochvil.net> (raw)
Hi Tom,
IMO mostly obvious, OK to check-in?
No regressions on {x86_64,x86_64-m32,i686}-fedora13-linux-gnu.
Thanks,
Jan
gdb/
2010-07-22 Jan Kratochvil <jan.kratochvil@redhat.com>
* dwarf2read.c: Include completer.h.
(save_gdb_index_command): Use matching usage command name.
(_initialize_dwarf2_read): New variable c, initialize it by add_cmd.
Set filename_completer for it.
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -53,6 +53,7 @@
#include "psympriv.h"
#include "exceptions.h"
#include "gdb_stat.h"
+#include "completer.h"
#include <fcntl.h>
#include "gdb_string.h"
@@ -14134,7 +14135,7 @@ save_gdb_index_command (char *arg, int from_tty)
struct objfile *objfile;
if (!arg || !*arg)
- error (_("usage: maintenance save-gdb-index DIRECTORY"));
+ error (_("usage: save gdb-index DIRECTORY"));
ALL_OBJFILES (objfile)
{
@@ -14179,6 +14180,8 @@ void _initialize_dwarf2_read (void);
void
_initialize_dwarf2_read (void)
{
+ struct cmd_list_element *c;
+
dwarf2_objfile_data_key
= register_objfile_data_with_cleanup (NULL, dwarf2_per_objfile_free);
@@ -14227,7 +14230,8 @@ The value is the maximum depth to print."),
NULL,
&setdebuglist, &showdebuglist);
- add_cmd ("gdb-index", class_files, save_gdb_index_command,
- _("Save a .gdb-index file"),
- &save_cmdlist);
+ c = add_cmd ("gdb-index", class_files, save_gdb_index_command,
+ _("Save a .gdb-index file"),
+ &save_cmdlist);
+ set_cmd_completer (c, filename_completer);
}
next reply other threads:[~2010-07-22 9:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 9:46 Jan Kratochvil [this message]
2010-07-22 15:54 ` Tom Tromey
2010-07-22 16:25 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100722094637.GA16205@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).