From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25226 invoked by alias); 22 Jul 2010 09:46:49 -0000 Received: (qmail 25215 invoked by uid 22791); 22 Jul 2010 09:46:48 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Jul 2010 09:46:43 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6M9kgOS019803 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 22 Jul 2010 05:46:42 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6M9kdh5014562 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Jul 2010 05:46:41 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o6M9kcwe012891; Thu, 22 Jul 2010 11:46:39 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o6M9kc3C011849; Thu, 22 Jul 2010 11:46:38 +0200 Date: Thu, 22 Jul 2010 09:46:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [patch] save gdb-index user interface fixups Message-ID: <20100722094637.GA16205@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00347.txt.bz2 Hi Tom, IMO mostly obvious, OK to check-in? No regressions on {x86_64,x86_64-m32,i686}-fedora13-linux-gnu. Thanks, Jan gdb/ 2010-07-22 Jan Kratochvil * dwarf2read.c: Include completer.h. (save_gdb_index_command): Use matching usage command name. (_initialize_dwarf2_read): New variable c, initialize it by add_cmd. Set filename_completer for it. --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -53,6 +53,7 @@ #include "psympriv.h" #include "exceptions.h" #include "gdb_stat.h" +#include "completer.h" #include #include "gdb_string.h" @@ -14134,7 +14135,7 @@ save_gdb_index_command (char *arg, int from_tty) struct objfile *objfile; if (!arg || !*arg) - error (_("usage: maintenance save-gdb-index DIRECTORY")); + error (_("usage: save gdb-index DIRECTORY")); ALL_OBJFILES (objfile) { @@ -14179,6 +14180,8 @@ void _initialize_dwarf2_read (void); void _initialize_dwarf2_read (void) { + struct cmd_list_element *c; + dwarf2_objfile_data_key = register_objfile_data_with_cleanup (NULL, dwarf2_per_objfile_free); @@ -14227,7 +14230,8 @@ The value is the maximum depth to print."), NULL, &setdebuglist, &showdebuglist); - add_cmd ("gdb-index", class_files, save_gdb_index_command, - _("Save a .gdb-index file"), - &save_cmdlist); + c = add_cmd ("gdb-index", class_files, save_gdb_index_command, + _("Save a .gdb-index file"), + &save_cmdlist); + set_cmd_completer (c, filename_completer); }