[patch] save gdb-index user interface fixups

[patch] save gdb-index user interface fixups

[Jan Kratochvil]

Hi Tom,

IMO mostly obvious, OK to check-in?

No regressions on {x86_64,x86_64-m32,i686}-fedora13-linux-gnu.


Thanks,
Jan


gdb/
2010-07-22  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* dwarf2read.c: Include completer.h.
	(save_gdb_index_command): Use matching usage command name.
	(_initialize_dwarf2_read): New variable c, initialize it by add_cmd.
	Set filename_completer for it.

--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -53,6 +53,7 @@
 #include "psympriv.h"
 #include "exceptions.h"
 #include "gdb_stat.h"
+#include "completer.h"
 
 #include <fcntl.h>
 #include "gdb_string.h"
@@ -14134,7 +14135,7 @@ save_gdb_index_command (char *arg, int from_tty)
   struct objfile *objfile;
 
   if (!arg || !*arg)
-    error (_("usage: maintenance save-gdb-index DIRECTORY"));
+    error (_("usage: save gdb-index DIRECTORY"));
 
   ALL_OBJFILES (objfile)
   {
@@ -14179,6 +14180,8 @@ void _initialize_dwarf2_read (void);
 void
 _initialize_dwarf2_read (void)
 {
+  struct cmd_list_element *c;
+
   dwarf2_objfile_data_key
     = register_objfile_data_with_cleanup (NULL, dwarf2_per_objfile_free);
 
@@ -14227,7 +14230,8 @@ The value is the maximum depth to print."),
 			    NULL,
 			    &setdebuglist, &showdebuglist);
 
-  add_cmd ("gdb-index", class_files, save_gdb_index_command,
-	   _("Save a .gdb-index file"),
-	   &save_cmdlist);
+  c = add_cmd ("gdb-index", class_files, save_gdb_index_command,
+	       _("Save a .gdb-index file"),
+	       &save_cmdlist);
+  set_cmd_completer (c, filename_completer);
 }

Re: [patch] save gdb-index user interface fixups

[Tom Tromey]

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:


Jan> IMO mostly obvious, OK to check-in?

Yes, thank you.

Tom

Re: [patch] save gdb-index user interface fixups

[Jan Kratochvil]

On Thu, 22 Jul 2010 17:54:14 +0200, Tom Tromey wrote:
> Yes, thank you.

Checked-in:
	http://sourceware.org/ml/gdb-cvs/2010-07/msg00132.html


Thanks,
Jan