From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch] enum target_signal vs. int host_signal
Date: Sat, 24 Jul 2010 22:44:00 -0000 [thread overview]
Message-ID: <201007242344.39745.pedro@codesourcery.com> (raw)
In-Reply-To: <20100724114208.GA8491@host1.dyn.jankratochvil.net>
On Saturday 24 July 2010 12:42:08, Jan Kratochvil wrote:
> Besides the change below I find some incorrect usage of gdb/gdbserver/target.h
> struct thread_resume -> sig. But one should decide first which kind of signal
> it should be.
Currently, host signal. I too see one place in server.c that got that
mixed up. And win32-low.c uses TARGET_SIGNAL_0 when it shouldn't.
I guess it would be a bit cleaner if thread_resume->sig was a
gdb signal instead, so that core gdbserver only handles gdb signals
(as is, there's a bit of a mix, since struct target_waitstatus holds
a gdb signal), though that's a larger change than just fixing the current
misuses.
> gdb/
> 2010-07-24 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * linux-nat.c (linux_nat_do_thread_registers): Convert STOP_SIGNAL to
> the host signal first.
Okay.
--
Pedro Alves
next prev parent reply other threads:[~2010-07-24 22:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-24 11:42 Jan Kratochvil
2010-07-24 22:44 ` Pedro Alves [this message]
2010-07-25 9:33 ` [patch] gdbserver: enum target_signal vs. int host_signal [Re: [patch] enum target_signal vs. int host_signal] Jan Kratochvil
2010-07-25 10:05 ` Pedro Alves
2010-07-25 10:17 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007242344.39745.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).