From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32611 invoked by alias); 24 Jul 2010 22:44:50 -0000 Received: (qmail 32601 invoked by uid 22791); 24 Jul 2010 22:44:49 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 24 Jul 2010 22:44:43 +0000 Received: (qmail 2632 invoked from network); 24 Jul 2010 22:44:41 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Jul 2010 22:44:41 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] enum target_signal vs. int host_signal Date: Sat, 24 Jul 2010 22:44:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.31-11-rt; KDE/4.4.2; x86_64; ; ) Cc: Jan Kratochvil References: <20100724114208.GA8491@host1.dyn.jankratochvil.net> In-Reply-To: <20100724114208.GA8491@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201007242344.39745.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00382.txt.bz2 On Saturday 24 July 2010 12:42:08, Jan Kratochvil wrote: > Besides the change below I find some incorrect usage of gdb/gdbserver/target.h > struct thread_resume -> sig. But one should decide first which kind of signal > it should be. Currently, host signal. I too see one place in server.c that got that mixed up. And win32-low.c uses TARGET_SIGNAL_0 when it shouldn't. I guess it would be a bit cleaner if thread_resume->sig was a gdb signal instead, so that core gdbserver only handles gdb signals (as is, there's a bit of a mix, since struct target_waitstatus holds a gdb signal), though that's a larger change than just fixing the current misuses. > gdb/ > 2010-07-24 Jan Kratochvil > > * linux-nat.c (linux_nat_do_thread_registers): Convert STOP_SIGNAL to > the host signal first. Okay. -- Pedro Alves