* [RFC 0/6] Fix lost siginfo_t
@ 2010-07-26 22:51 Jan Kratochvil
2010-07-27 8:01 ` Mark Kettenis
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kratochvil @ 2010-07-26 22:51 UTC (permalink / raw)
To: gdb-patches
Hi,
currently GDB's postponing and resending signals across threads drops the
associated siginfo_t information. This can break real world inferiors
https://bugzilla.redhat.com/attachment.cgi?id=413842
and it is also tested by a new testcase.
IMO all current `int status', `int host_signal' and `enum target_signal'
should be associated with their siginfo_t as otherwise they carry incomplete
information. This is implemented by this patchset although it brings
sizeof (target_signal) to 136. It is currently passed by value everywhere, it
could be either just shortened to 48 bytes or some pointer / reference
counting could be implemented. It is true I would not change it myself
without a request as x86* host machines cannot notice such a small overhead.
There are some details to tune up but I would welcome to get some preliminary
approval of the approach before some more details + ChangeLogs get tuned up.
No regressions on {x86_64,x86_64-m32,i686}-fedora13-linux-gnu, with new KFAIL:
http://sourceware.org/bugzilla/show_bug.cgi?id=11842
Currently it has some runtime + compilation regressions on non-x86* arches.
Thanks,
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC 0/6] Fix lost siginfo_t
2010-07-26 22:51 [RFC 0/6] Fix lost siginfo_t Jan Kratochvil
@ 2010-07-27 8:01 ` Mark Kettenis
2010-08-30 7:19 ` obsoleted: " Jan Kratochvil
0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2010-07-27 8:01 UTC (permalink / raw)
To: jan.kratochvil; +Cc: gdb-patches
> Date: Tue, 27 Jul 2010 00:50:54 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Hi,
>
> currently GDB's postponing and resending signals across threads drops the
> associated siginfo_t information. This can break real world inferiors
> https://bugzilla.redhat.com/attachment.cgi?id=413842
> and it is also tested by a new testcase.
>
> IMO all current `int status', `int host_signal' and `enum
> target_signal' should be associated with their siginfo_t as
> otherwise they carry incomplete information. This is implemented by
> this patchset although it brings sizeof (target_signal) to 136. It
> is currently passed by value everywhere, it could be either just
> shortened to 48 bytes or some pointer / reference counting could be
> implemented. It is true I would not change it myself without a
> request as x86* host machines cannot notice such a small overhead.
Sorry, but I think the idea here is seriously flawed. How are you
going to pass around the siginfo_t on non-native/multi-arch GDB?
^ permalink raw reply [flat|nested] 3+ messages in thread
* obsoleted: Re: [RFC 0/6] Fix lost siginfo_t
2010-07-27 8:01 ` Mark Kettenis
@ 2010-08-30 7:19 ` Jan Kratochvil
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kratochvil @ 2010-08-30 7:19 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb-patches
On Tue, 27 Jul 2010 10:01:21 +0200, Mark Kettenis wrote:
> Sorry, but I think the idea here is seriously flawed. How are you
> going to pass around the siginfo_t on non-native/multi-arch GDB?
Thanks, addressed in the new patchset:
[0/9]#2 Fix lost siginfo_t
http://sourceware.org/ml/gdb-patches/2010-08/msg00480.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-30 7:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-26 22:51 [RFC 0/6] Fix lost siginfo_t Jan Kratochvil
2010-07-27 8:01 ` Mark Kettenis
2010-08-30 7:19 ` obsoleted: " Jan Kratochvil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).