From: Daniel Jacobowitz <dan@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC 5/6] Associate siginfo_t with any signal
Date: Tue, 27 Jul 2010 14:50:00 -0000 [thread overview]
Message-ID: <20100727145041.GB3747@caradoc.them.org> (raw)
In-Reply-To: <20100726225122.GF3597@host1.dyn.jankratochvil.net>
On Tue, Jul 27, 2010 at 12:51:22AM +0200, Jan Kratochvil wrote:
> this patch brings the primary fix of this patchset. siginfo_t gets associated
> with every signal (both target_signal_t and int host_signal).
>
> <signal.h> included from "gdb/signals.h" is fatal on ppc64-rhel55 host with
> --enable-targets=all as there are various conflicts like:
>
> In file included from mips-linux-tdep.c:39:
> mips-linux-tdep.h:21:1: error: "ELF_NGREG" redefined
> In file included from /usr/include/asm/sigcontext.h:12,
> from /usr/include/bits/sigcontext.h:28,
> from /usr/include/signal.h:333,
> from ./../include/gdb/signals.h:24,
> from defs.h:68,
> from mips-linux-tdep.c:21:
> /usr/include/asm/elf.h:91:1: error: this is the location of the previous definition
> make[2]: *** [mips-linux-tdep.o] Error 1
>
> I believe *-tdep.h file must not define such a general symbol as "ELF_NGREG".
> I can fix these *-tdep.* files if this way gets approved.
Mark K. is right. Host files like signal.h should not be included in
most of GDB, to prevent people from accidentally using the native
types. There's no promise that a native siginfo_t has any resemblence
to a target siginfo_t.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-07-27 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 22:52 Jan Kratochvil
2010-07-27 14:50 ` Daniel Jacobowitz [this message]
2010-08-30 7:21 ` obsoleted: " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727145041.GB3747@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).