From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Balazs Kezes <rlblaster@gmail.com>
Subject: Re: [patch] Call tui_resize_all() after a resize
Date: Tue, 27 Jul 2010 14:38:00 -0000 [thread overview]
Message-ID: <201007271537.48467.pedro@codesourcery.com> (raw)
In-Reply-To: <AANLkTin1PGgSGf571uY0oTogSbUn24KmbEazbTYKNwcC@mail.gmail.com>
On Wednesday 21 July 2010 21:53:01, Balazs Kezes wrote:
> Currently tui_resize_all is never called. This could be called from the
> SIGWINCH handler but because the resize logic is a bit complex it is safer
> to mark a global variable and call this function later. The marking in the
> handler is already in the code.
> The global variable is currently also marked in this tui_resize_all so this
> patch removes it from there.
Thanks, this version looks good. I can apply it. Can you write me a
change log entry for this?
>
> --
> Balazs
>
> Index: tui-io.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/tui/tui-io.c,v
> retrieving revision 1.23
> diff -c -p -r1.23 tui-io.c
> *** tui-io.c 25 May 2010 15:48:44 -0000 1.23
> --- tui-io.c 21 Jul 2010 20:34:54 -0000
> *************** tui_handle_resize_during_io (unsigned in
> *** 711,716 ****
> --- 711,717 ----
> {
> if (tui_win_resized ())
> {
> + tui_resize_all ();
> tui_refresh_all_win ();
> dont_repeat ();
> tui_set_win_resized_to (FALSE);
> Index: tui-win.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/tui/tui-win.c,v
> retrieving revision 1.47
> diff -c -p -r1.47 tui-win.c
> *** tui-win.c 17 May 2010 22:21:43 -0000 1.47
> --- tui-win.c 21 Jul 2010 20:43:22 -0000
> *************** tui_resize_all (void)
> *** 799,805 ****
> tui_win_list[win_type] = (struct tui_win_info *) NULL;
> }
> }
> - tui_set_win_resized_to (TRUE);
> /* Turn keypad back on, unless focus is in the command
> window. */
> if (win_with_focus != TUI_CMD_WIN)
>
next prev parent reply other threads:[~2010-07-27 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 20:53 Balazs Kezes
2010-07-27 14:38 ` Pedro Alves [this message]
2010-07-28 11:57 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007271537.48467.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=rlblaster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).