From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21605 invoked by alias); 27 Jul 2010 14:38:34 -0000 Received: (qmail 21591 invoked by uid 22791); 27 Jul 2010 14:38:32 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Jul 2010 14:37:55 +0000 Received: (qmail 9629 invoked from network); 27 Jul 2010 14:37:53 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Jul 2010 14:37:53 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] Call tui_resize_all() after a resize Date: Tue, 27 Jul 2010 14:38:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.32-24-generic; KDE/4.4.2; x86_64; ; ) Cc: Balazs Kezes References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201007271537.48467.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00420.txt.bz2 On Wednesday 21 July 2010 21:53:01, Balazs Kezes wrote: > Currently tui_resize_all is never called. This could be called from the > SIGWINCH handler but because the resize logic is a bit complex it is safer > to mark a global variable and call this function later. The marking in the > handler is already in the code. > The global variable is currently also marked in this tui_resize_all so this > patch removes it from there. Thanks, this version looks good. I can apply it. Can you write me a change log entry for this? > > -- > Balazs > > Index: tui-io.c > =================================================================== > RCS file: /cvs/src/src/gdb/tui/tui-io.c,v > retrieving revision 1.23 > diff -c -p -r1.23 tui-io.c > *** tui-io.c 25 May 2010 15:48:44 -0000 1.23 > --- tui-io.c 21 Jul 2010 20:34:54 -0000 > *************** tui_handle_resize_during_io (unsigned in > *** 711,716 **** > --- 711,717 ---- > { > if (tui_win_resized ()) > { > + tui_resize_all (); > tui_refresh_all_win (); > dont_repeat (); > tui_set_win_resized_to (FALSE); > Index: tui-win.c > =================================================================== > RCS file: /cvs/src/src/gdb/tui/tui-win.c,v > retrieving revision 1.47 > diff -c -p -r1.47 tui-win.c > *** tui-win.c 17 May 2010 22:21:43 -0000 1.47 > --- tui-win.c 21 Jul 2010 20:43:22 -0000 > *************** tui_resize_all (void) > *** 799,805 **** > tui_win_list[win_type] = (struct tui_win_info *) NULL; > } > } > - tui_set_win_resized_to (TRUE); > /* Turn keypad back on, unless focus is in the command > window. */ > if (win_with_focus != TUI_CMD_WIN) >