New ARI warning Wed Jul 14 01:55:54 UTC 2010

New ARI warning Wed Jul 14 01:55:54 UTC 2010

[GDB Administrator]

292a293
> gdb/dwarf2read.c:2284: gettext: trailing new line: A message should not have a trailing new line
gdb/dwarf2read.c:2284:    warning (_("(Internal error: pc %s in read in CU, but not in symtab.)\n"),

Re: New ARI warning Wed Jul 14 01:55:54 UTC 2010

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

> > gdb/dwarf2read.c:2284: gettext: trailing new line: A message should not have a trailing new line
> gdb/dwarf2read.c:2284:    warning (_("(Internal error: pc %s in read in CU, but not in symtab.)\n"),

I fixed that one thusly.  The warning seems incorrectly phrased, but
I left it alone.

2010-07-27  Joel Brobecker  <brobecker@adacore.com>

        * dwarf2read.c (dw2_find_pc_sect_symtab): Remove trailing newline
        in warning message.

-- 
Joel

[-- Attachment #2: dwarf2read.c.diff --]
[-- Type: text/x-diff, Size: 677 bytes --]

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.427
diff -u -u -p -r1.427 dwarf2read.c
--- dwarf2read.c	27 Jul 2010 07:57:49 -0000	1.427
+++ dwarf2read.c	27 Jul 2010 16:15:27 -0000
@@ -2394,7 +2394,7 @@ dw2_find_pc_sect_symtab (struct objfile 
     return NULL;
 
   if (warn_if_readin && data->v.quick->symtab)
-    warning (_("(Internal error: pc %s in read in CU, but not in symtab.)\n"),
+    warning (_("(Internal error: pc %s in read in CU, but not in symtab.)"),
 	     paddress (get_objfile_arch (objfile), pc));
 
   return dw2_instantiate_symtab (objfile, data);

Re: New ARI warning Wed Jul 14 01:55:54 UTC 2010

[Tom Tromey]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> > gdb/dwarf2read.c:2284: gettext: trailing new line: A message should not have a trailing new line
>> gdb/dwarf2read.c:2284:    warning (_("(Internal error: pc %s in read in CU, but not in symtab.)\n"),

Joel> I fixed that one thusly.  The warning seems incorrectly phrased, but
Joel> I left it alone.

Thanks.  This error is a little oddly phrased, but it has been that way
forever, so I just left it alone.

Tom

Re: New ARI warning Wed Jul 14 01:55:54 UTC 2010

[Joel Brobecker]

> >> gdb/dwarf2read.c:2284:    warning (_("(Internal error: pc %s in read in CU, but not in symtab.)\n"),
> 
> Joel> I fixed that one thusly.  The warning seems incorrectly phrased, but
> Joel> I left it alone.
> 
> Thanks.  This error is a little oddly phrased, but it has been that way
> forever, so I just left it alone.

I'm just slowly getting the meaning of this warning, and I think that
maybe adding a hyphen might help:

        Internal error: pc %s in read-in CU, but not in symtab.

Either way, we both opted to leave it alone, and it should rarely show
up, so no problem if we leave this unchanged.

-- 
Joel