From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16921 invoked by alias); 27 Jul 2010 16:18:34 -0000 Received: (qmail 16909 invoked by uid 22791); 27 Jul 2010 16:18:33 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,TW_BJ X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Jul 2010 16:18:29 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 648F82BAACB; Tue, 27 Jul 2010 12:18:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id WF-UGeLxSQIW; Tue, 27 Jul 2010 12:18:27 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2F5482BAAC7; Tue, 27 Jul 2010 12:18:27 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 758E7F58FA; Tue, 27 Jul 2010 09:18:23 -0700 (PDT) Date: Tue, 27 Jul 2010 16:18:00 -0000 From: Joel Brobecker To: GDB Administrator Cc: gdb-patches@sourceware.org Subject: Re: New ARI warning Wed Jul 14 01:55:54 UTC 2010 Message-ID: <20100727161823.GE13267@adacore.com> References: <20100714015555.GA13409@sourceware.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="W/nzBZO5zC0uMSeA" Content-Disposition: inline In-Reply-To: <20100714015555.GA13409@sourceware.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00431.txt.bz2 --W/nzBZO5zC0uMSeA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 457 > > gdb/dwarf2read.c:2284: gettext: trailing new line: A message should not have a trailing new line > gdb/dwarf2read.c:2284: warning (_("(Internal error: pc %s in read in CU, but not in symtab.)\n"), I fixed that one thusly. The warning seems incorrectly phrased, but I left it alone. 2010-07-27 Joel Brobecker * dwarf2read.c (dw2_find_pc_sect_symtab): Remove trailing newline in warning message. -- Joel --W/nzBZO5zC0uMSeA Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="dwarf2read.c.diff" Content-length: 677 Index: dwarf2read.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.427 diff -u -u -p -r1.427 dwarf2read.c --- dwarf2read.c 27 Jul 2010 07:57:49 -0000 1.427 +++ dwarf2read.c 27 Jul 2010 16:15:27 -0000 @@ -2394,7 +2394,7 @@ dw2_find_pc_sect_symtab (struct objfile return NULL; if (warn_if_readin && data->v.quick->symtab) - warning (_("(Internal error: pc %s in read in CU, but not in symtab.)\n"), + warning (_("(Internal error: pc %s in read in CU, but not in symtab.)"), paddress (get_objfile_arch (objfile), pc)); return dw2_instantiate_symtab (objfile, data); --W/nzBZO5zC0uMSeA--