From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27432 invoked by alias); 27 Jul 2010 22:46:55 -0000 Received: (qmail 27422 invoked by uid 22791); 27 Jul 2010 22:46:54 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Jul 2010 22:46:50 +0000 Received: (qmail 11543 invoked from network); 27 Jul 2010 22:46:48 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Jul 2010 22:46:48 -0000 From: Pedro Alves To: Balazs Kezes Subject: Re: [patch] Correct origin calculation of command line window in TUI mode Date: Tue, 27 Jul 2010 22:46:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.32-24-generic; KDE/4.4.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201007271543.13838.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201007272346.46299.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00454.txt.bz2 On Tuesday 27 July 2010 23:38:02, Balazs Kezes wrote: > > Hmmm, I've tried all three patches together, and I still get a messed > > up cmd window after a couple of resizes (e.g., start > > maxized/unmaximize/maximize). > > Yeah, these 3 patches are not enough. There are two remaining modifications > which need to be done: Ah. > 1) HAVE_RESIZE_TERM - to make sure ncurses knows about the terminal size. > Somehow this needs to be added to the configuration. I'm not sure how to do > this. Maybe I'll look into this sometime. I'll do this. These three patches now put you at borderline of what we can accept without copyright assignment to the FSF. Do you have that taken care of? If not, let us know, and we'll start you on the process. > 2) The readline modification in order to have correct sizes. I've already > contacted the readline guys and they told me that this bug will be fixed in > readline 6.2. That's good news. In that case, I don't think there's a problem in backporting the fix to our local copy. Distros can do the same to their system readline's if they care too. > Even after this there is a little annoyance that you need to press a > key to actually resize and redraw everything, but this could be fixed > by ungetc or with a similar hack. > > Here are the changelogs: Thanks. I'll take another look at this soon. -- Pedro Alves