public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Cheng Renquan <crquan@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: MAINTAINERS: Add myself for write after approval privileges.
Date: Wed, 28 Jul 2010 04:17:00 -0000	[thread overview]
Message-ID: <20100728041724.GJ13267@adacore.com> (raw)
In-Reply-To: <AANLkTinV9L3Yx1unbsnmMpvr+mXaiDMY_R2X28vPhzrF@mail.gmail.com>

> add-myself-for-write-after-approval-privileges.patch
> 
> To Joel, sorry to mess things up again,

Not to worry. Welcome to the project.

I don't remember if I said this explicitly in my other email, but obvious
patches do not require approval before being checked in.  I invite you
to have a look at the MAINTAINERS file again, if you are not familiar
with the "Obvious Fix Rule" and what constitutes an obvious fix and what
doesn't.  It is always fine to err on the side of caution :).

That being said, you patch revealed that alphabetical order for
the write-after-approval list has been broken by the last couple of
entries. I fixed that, but you will need to redo your patch to insert
your name at the correct location. (no need to wait for approval, just
post the patch as usual, saying that you checked it in).

One last thing: Once you have checked in a patch that was approved,
can you send a followup email confirming the commit? It is customary
to do so and helps keeping track of which patches have been checked in
and which ones haven't.

-- 
Joel

  reply	other threads:[~2010-07-28  4:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-27 20:56 Cheng Renquan
2010-07-28  4:17 ` Joel Brobecker [this message]
2010-07-31  1:47 ` [commit] " Cheng Renquan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100728041724.GJ13267@adacore.com \
    --to=brobecker@adacore.com \
    --cc=crquan@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).