From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20660 invoked by alias); 28 Jul 2010 17:39:07 -0000 Received: (qmail 20650 invoked by uid 22791); 28 Jul 2010 17:39:06 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Jul 2010 17:39:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E13142BAC17; Wed, 28 Jul 2010 13:39:01 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id iW3+YWBM27wF; Wed, 28 Jul 2010 13:39:01 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B020C2BAB45; Wed, 28 Jul 2010 13:39:01 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 51107F58FA; Wed, 28 Jul 2010 10:38:51 -0700 (PDT) Date: Wed, 28 Jul 2010 17:39:00 -0000 From: Joel Brobecker To: Phil Muldoon Cc: gdb-patches ml Subject: Re: [patch] Add solib_address and decode_line Python functionality Message-ID: <20100728173851.GP13267@adacore.com> References: <4C44728D.4040408@redhat.com> <20100727162545.GF13267@adacore.com> <4C5015E2.4000205@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C5015E2.4000205@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00495.txt.bz2 > What do you think? Looks very good to me :). But I did not review the code itself, because of lack of familiarity with the Python part. I can take a look, if it helps, but this will have to wait until I get back to a normal schedule, which might not be until the end of Aug :-(. -- Joel