From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18010 invoked by alias); 28 Jul 2010 18:07:49 -0000 Received: (qmail 18002 invoked by uid 22791); 28 Jul 2010 18:07:49 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Jul 2010 18:07:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E85D32BAC21 for ; Wed, 28 Jul 2010 14:07:41 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id oO5p21j7jPWT for ; Wed, 28 Jul 2010 14:07:41 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B45AC2BAC20 for ; Wed, 28 Jul 2010 14:07:41 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 54A8EF58FA; Wed, 28 Jul 2010 11:07:31 -0700 (PDT) Date: Wed, 28 Jul 2010 18:07:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: New ARI warning Fri Jul 2 01:53:49 UTC 2010 Message-ID: <20100728180731.GS13267@adacore.com> References: <20100702015349.GA10024@sourceware.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MfFXiAuoTsnnDAfZ" Content-Disposition: inline In-Reply-To: <20100702015349.GA10024@sourceware.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00501.txt.bz2 --MfFXiAuoTsnnDAfZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 689 > > gdb/remote.c:2787: code: sprintf: Do not use sprintf, instead use xstrprintf > gdb/remote.c:2787: sprintf (p, '); > 1161a1163 > > gdb/remote.c:9747: gettext: _ markup: All messages should be marked up with _. > gdb/remote.c:9747: error ("Static tracepoint not valid during download"); > 1450,1451d1451 > > gdb/tracepoint.c:4133: gettext: _ markup: All messages should be marked up with _. > gdb/tracepoint.c:4133: error ("bad marker definition: %s", line); I fixed those thusly. I don't know how to say this without sounding like I am complaining, but I had hoped that we would all look at those reports and that whoever caused the new warnings would act to fix them. -- Joel --MfFXiAuoTsnnDAfZ Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="ari.diff" Content-length: 1846 commit fe7232e92fa10789ade5a9d414b5e61e30463523 Author: Joel Brobecker Date: Wed Jul 28 11:03:34 2010 -0700 Add missing gettext markup. gdb/ChangeLog: * remote.c (remote_download_tracepoint): Add missing gettext markup. * tracepoint.c (parse_static_tracepoint_marker_definition): Likewise. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 630de2d..e74823c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2010-07-28 Joel Brobecker + * remote.c (remote_download_tracepoint): Add missing gettext markup. + * tracepoint.c (parse_static_tracepoint_marker_definition): Likewise. + +2010-07-28 Joel Brobecker + * breakpoint.c (breakpoint_re_set_one): Move call to set_language down, just before the block that parse the breakpoint addr_string. diff --git a/gdb/remote.c b/gdb/remote.c index 71eee5d..e42e57f 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -9746,7 +9746,7 @@ remote_download_tracepoint (struct breakpoint *t) if (target_static_tracepoint_marker_at (tpaddr, &marker)) strcat (buf, ":S"); else - error ("Static tracepoint not valid during download"); + error (_("Static tracepoint not valid during download")); } else /* Fast tracepoints are functionally identical to regular diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c index 80be63e..b8b9d8c 100644 --- a/gdb/tracepoint.c +++ b/gdb/tracepoint.c @@ -4128,7 +4128,7 @@ parse_static_tracepoint_marker_definition (char *line, char **pp, endp = strchr (p, ':'); if (endp == NULL) - error ("bad marker definition: %s", line); + error (_("bad marker definition: %s"), line); marker->str_id = xmalloc (endp - p + 1); end = hex2bin (p, (gdb_byte *) marker->str_id, (endp - p + 1) / 2); --MfFXiAuoTsnnDAfZ--