From: DJ Delorie <dj@redhat.com>
To: gdb-patches@sourceware.org
Cc: kevinb@redhat.com
Subject: gdb-rx-tdep: make RXO_branch more robust
Date: Thu, 29 Jul 2010 02:29:00 -0000 [thread overview]
Message-ID: <201007290229.o6T2T9rm023183@greed.delorie.com> (raw)
My next sim patch changes RXO_branch to not have a condition for
unconditional branches (as opposed to the "always true" condition).
Regardless, I think there's no need to check for RX_Operand_Condition
anyway - previously, it was the *only* value that type could be, for
RXO_branch. I'd change it to check for unconditional, but I don't
want to break things between this patch and the next. Ok?
* rx-tdep.c (rx_analyze_prologue): Don't require branches to have
conditions.
Index: gdb/rx-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rx-tdep.c,v
retrieving revision 1.3
diff -p -U3 -r1.3 rx-tdep.c
--- gdb/rx-tdep.c 24 Jun 2010 20:38:04 -0000 1.3
+++ gdb/rx-tdep.c 29 Jul 2010 02:25:34 -0000
@@ -296,7 +296,6 @@ rx_analyze_prologue (CORE_ADDR start_pc,
}
else if (opc.id == RXO_branch
&& opc.op[0].type == RX_Operand_Immediate
- && opc.op[1].type == RX_Operand_Condition
&& next_pc < opc.op[0].addend)
{
/* When a loop appears as the first statement of a function
next reply other threads:[~2010-07-29 2:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 2:29 DJ Delorie [this message]
2010-07-29 5:13 ` Kevin Buettner
2010-07-29 17:35 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007290229.o6T2T9rm023183@greed.delorie.com \
--to=dj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).