From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4842 invoked by alias); 29 Jul 2010 02:29:18 -0000 Received: (qmail 4829 invoked by uid 22791); 29 Jul 2010 02:29:17 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Jul 2010 02:29:13 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6T2TBTk014502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Jul 2010 22:29:11 -0400 Received: from greed.delorie.com ([10.3.112.10]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6T2T9mk018818 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 28 Jul 2010 22:29:11 -0400 Received: from greed.delorie.com (greed.delorie.com [127.0.0.1] (may be forged)) by greed.delorie.com (8.14.3/8.14.3) with ESMTP id o6T2T9ko023186; Wed, 28 Jul 2010 22:29:09 -0400 Received: (from dj@localhost) by greed.delorie.com (8.14.3/8.14.3/Submit) id o6T2T9rm023183; Wed, 28 Jul 2010 22:29:09 -0400 Date: Thu, 29 Jul 2010 02:29:00 -0000 Message-Id: <201007290229.o6T2T9rm023183@greed.delorie.com> From: DJ Delorie To: gdb-patches@sourceware.org CC: kevinb@redhat.com Subject: gdb-rx-tdep: make RXO_branch more robust X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00536.txt.bz2 My next sim patch changes RXO_branch to not have a condition for unconditional branches (as opposed to the "always true" condition). Regardless, I think there's no need to check for RX_Operand_Condition anyway - previously, it was the *only* value that type could be, for RXO_branch. I'd change it to check for unconditional, but I don't want to break things between this patch and the next. Ok? * rx-tdep.c (rx_analyze_prologue): Don't require branches to have conditions. Index: gdb/rx-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/rx-tdep.c,v retrieving revision 1.3 diff -p -U3 -r1.3 rx-tdep.c --- gdb/rx-tdep.c 24 Jun 2010 20:38:04 -0000 1.3 +++ gdb/rx-tdep.c 29 Jul 2010 02:25:34 -0000 @@ -296,7 +296,6 @@ rx_analyze_prologue (CORE_ADDR start_pc, } else if (opc.id == RXO_branch && opc.op[0].type == RX_Operand_Immediate - && opc.op[1].type == RX_Operand_Condition && next_pc < opc.op[0].addend) { /* When a loop appears as the first statement of a function