* gdb-rx-tdep: make RXO_branch more robust
@ 2010-07-29 2:29 DJ Delorie
2010-07-29 5:13 ` Kevin Buettner
0 siblings, 1 reply; 3+ messages in thread
From: DJ Delorie @ 2010-07-29 2:29 UTC (permalink / raw)
To: gdb-patches; +Cc: kevinb
My next sim patch changes RXO_branch to not have a condition for
unconditional branches (as opposed to the "always true" condition).
Regardless, I think there's no need to check for RX_Operand_Condition
anyway - previously, it was the *only* value that type could be, for
RXO_branch. I'd change it to check for unconditional, but I don't
want to break things between this patch and the next. Ok?
* rx-tdep.c (rx_analyze_prologue): Don't require branches to have
conditions.
Index: gdb/rx-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rx-tdep.c,v
retrieving revision 1.3
diff -p -U3 -r1.3 rx-tdep.c
--- gdb/rx-tdep.c 24 Jun 2010 20:38:04 -0000 1.3
+++ gdb/rx-tdep.c 29 Jul 2010 02:25:34 -0000
@@ -296,7 +296,6 @@ rx_analyze_prologue (CORE_ADDR start_pc,
}
else if (opc.id == RXO_branch
&& opc.op[0].type == RX_Operand_Immediate
- && opc.op[1].type == RX_Operand_Condition
&& next_pc < opc.op[0].addend)
{
/* When a loop appears as the first statement of a function
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gdb-rx-tdep: make RXO_branch more robust
2010-07-29 2:29 gdb-rx-tdep: make RXO_branch more robust DJ Delorie
@ 2010-07-29 5:13 ` Kevin Buettner
2010-07-29 17:35 ` DJ Delorie
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Buettner @ 2010-07-29 5:13 UTC (permalink / raw)
To: gdb-patches
On Wed, 28 Jul 2010 22:29:09 -0400
DJ Delorie <dj@redhat.com> wrote:
>
> My next sim patch changes RXO_branch to not have a condition for
> unconditional branches (as opposed to the "always true" condition).
> Regardless, I think there's no need to check for RX_Operand_Condition
> anyway - previously, it was the *only* value that type could be, for
> RXO_branch. I'd change it to check for unconditional, but I don't
> want to break things between this patch and the next. Ok?
>
> * rx-tdep.c (rx_analyze_prologue): Don't require branches to have
> conditions.
Okay.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gdb-rx-tdep: make RXO_branch more robust
2010-07-29 5:13 ` Kevin Buettner
@ 2010-07-29 17:35 ` DJ Delorie
0 siblings, 0 replies; 3+ messages in thread
From: DJ Delorie @ 2010-07-29 17:35 UTC (permalink / raw)
To: Kevin Buettner; +Cc: gdb-patches
Thanks, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-29 17:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-07-29 2:29 gdb-rx-tdep: make RXO_branch more robust DJ Delorie
2010-07-29 5:13 ` Kevin Buettner
2010-07-29 17:35 ` DJ Delorie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).