From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26195 invoked by alias); 30 Jul 2010 18:56:47 -0000 Received: (qmail 26185 invoked by uid 22791); 30 Jul 2010 18:56:46 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 30 Jul 2010 18:56:41 +0000 Received: from kpbe15.cbf.corp.google.com (kpbe15.cbf.corp.google.com [172.25.105.79]) by smtp-out.google.com with ESMTP id o6UIuRak013346; Fri, 30 Jul 2010 11:56:27 -0700 Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.18.118.116]) by kpbe15.cbf.corp.google.com with ESMTP id o6UIuPh4019513; Fri, 30 Jul 2010 11:56:26 -0700 Received: by ruffy.mtv.corp.google.com (Postfix, from userid 67641) id C14D584561; Fri, 30 Jul 2010 11:56:25 -0700 (PDT) To: gdb-patches@sourceware.org, tromey@redhat.com Subject: [commit] xfail some py-type.exp tests for gcc 4.4 and earlier Message-Id: <20100730185625.C14D584561@ruffy.mtv.corp.google.com> Date: Fri, 30 Jul 2010 18:56:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00588.txt.bz2 Hi. ref: http://sourceware.org/ml/gdb-patches/2010-07/msg00522.html I'm getting these failures with gcc 4.4: [amd64-linux] FAIL: gdb.python/py-type.exp: python print ttype.template_argument(1) FAIL: gdb.python/py-type.exp: python print isinstance(ttype.template_argument(1), gdb.Value) I built a copy of gcc 4.5 to see what happens there, they pass. So I've committed this: 2010-07-30 Doug Evans * gdb.python/py-type.exp (test_template): Mark as xfail tests "python print ttype.template_argument(1)" and "python print isinstance(ttype.template_argument(1), gdb.Value)" if using gcc 4.4 or earlier. Index: gdb.python/py-type.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.python/py-type.exp,v retrieving revision 1.6 diff -u -p -r1.6 py-type.exp --- gdb.python/py-type.exp 28 Jul 2010 20:50:17 -0000 1.6 +++ gdb.python/py-type.exp 30 Jul 2010 18:42:35 -0000 @@ -24,6 +24,10 @@ set testfile "py-type" set srcfile ${testfile}.c set binfile ${objdir}/${subdir}/${testfile} +if [get_compiler_info not-used c++] { + return -1; +} + # Build inferior to language specification. proc build_inferior {lang} { global srcdir subdir srcfile binfile testfile hex @@ -136,10 +140,20 @@ proc test_template {} { gdb_test "python print ttype.template_argument(0)" "D" gdb_test "python print isinstance(ttype.template_argument(0), gdb.Type)" \ "True" + # The next two tests require a GCC that emits DW_TAG_template_*. + # GCC 4.4 does not emit it, 4.5 and 6 do emit it. + set have_older_gcc 0 + if {[test_compiler_info {gcc-[0-3]-*}] + || [test_compiler_info {gcc-4-[0-4]-*}]} { + set have_older_gcc 1 + } + if $have_older_gcc { setup_xfail *-*-* } gdb_test "python print ttype.template_argument(1)" "23" + if $have_older_gcc { setup_xfail *-*-* } gdb_test "python print isinstance(ttype.template_argument(1), gdb.Value)" \ "True" + setup_kfail "gcc/41736" *-*-* gdb_test "python print ttype.template_argument(2)" "&C::c" }