public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [commit] Forward "c++" option to get_compiler_info.
Date: Fri, 30 Jul 2010 20:03:00 -0000	[thread overview]
Message-ID: <20100730200306.ACE1084561@ruffy.mtv.corp.google.com> (raw)

Hi.

While testing another fix I was running the test with

runtest CXX_FOR_TARGET=/foo/g++ bar.exp

This failed because the wrong compiler was being used by
get_compiler_info.
The test is a c++ test and get_compiler_info was invoking gcc instead
of the g++ I specified.

Committed.

2010-07-30  Doug Evans  <dje@google.com>

	* lib/gdb.exp (build_executable): Forward "c++" option to
	get_compiler_info.

Index: lib/gdb.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v
retrieving revision 1.156
diff -u -p -r1.156 gdb.exp
--- lib/gdb.exp	29 Jul 2010 14:18:57 -0000	1.156
+++ lib/gdb.exp	30 Jul 2010 19:58:39 -0000
@@ -3257,7 +3257,11 @@ proc build_executable { testname executa
         return -1
     }
 
-    if [get_compiler_info ${binfile}] {
+    set info_options ""
+    if { [lsearch -exact $options "c++"] >= 0 } {
+	set info_options "c++"
+    }
+    if [get_compiler_info ${binfile} ${info_options}] {
         return -1
     }
     return 0

                 reply	other threads:[~2010-07-30 20:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100730200306.ACE1084561@ruffy.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).