Re: [rfa] frame address size incorrect if address size != ptr size

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Wed, 04 Aug 2010 13:35:01 +0200, Corinna Vinschen wrote:
> Ping?  This affects generic code in dwarf2-frame.c...
> 
> On Jul 26 16:52, Corinna Vinschen wrote:
[...]
>   /* The target address size.  For .eh_frame FDEs this is considered
>      equal to the size of a target pointer.  For .dwarf_frame FDEs,
                                                   ^^^^^^^^^^^^ = .debug_frame
>      this is supposed to be the target address size from the associated
>      CU header.  FIXME: We do not have a good way to determine the
>      latter.  Always use the target pointer size for now.  */
>   cie->addr_size = gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT;
[...]
> Therefore I propose the below patch.  It continues to compute addr_size
> from gdbarch_ptr_bit for .eh_frame sections, but uses gdbarch_addr_bit
> in case of .dwarf_frame sections.
             ^^^^^^^^^^^^ = .debug_frame
             
I find the GDB comment above to be obsolete now.  FSF GCC (at least 4.4+ at
least x86_64-linux) no longer generates .debug_frame sections (unless you
explicitly use -fno-asynchronous-unwind-tables) as generated .eh_frame
sections already contains all the needed info.

I have not built gcc for the xstrormy16 target to check it more.  Still
I believe .eh_frame and .dwarf_frame address size should be treated the same.


Regards,
Jan