From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28252 invoked by alias); 6 Aug 2010 14:19:26 -0000 Received: (qmail 28235 invoked by uid 22791); 6 Aug 2010 14:19:24 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Aug 2010 14:18:52 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o76EIpOO002721 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 6 Aug 2010 10:18:51 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o76EImZG011776 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 6 Aug 2010 10:18:50 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o76EImeT018524 for ; Fri, 6 Aug 2010 16:18:48 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o76EImpb018522 for gdb-patches@sourceware.org; Fri, 6 Aug 2010 16:18:48 +0200 Date: Fri, 06 Aug 2010 14:19:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [obv] [mi] code cleanup: varobj_create variables move Message-ID: <20100806141847.GA15006@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00064.txt.bz2 Checked-in. http://sourceware.org/ml/gdb-cvs/2010-08/msg00024.html --- src/gdb/ChangeLog 2010/08/05 16:19:18 1.12061 +++ src/gdb/ChangeLog 2010/08/06 14:17:55 1.12062 @@ -1,3 +1,9 @@ +2010-08-06 Jan Kratochvil + + Code cleanup. + * varobj.c (varobj_create): Move variables fi, old_fi and block to + a more inner block. + 2010-08-05 Pedro Alves * configure.tgt (alpha*-*-linux*, am33_2.0*-*-linux*, frv-*-*) --- src/gdb/varobj.c 2010/05/17 18:48:52 1.158 +++ src/gdb/varobj.c 2010/08/06 14:17:56 1.159 @@ -528,9 +528,6 @@ char *expression, CORE_ADDR frame, enum varobj_type type) { struct varobj *var; - struct frame_info *fi; - struct frame_info *old_fi = NULL; - struct block *block; struct cleanup *old_chain; /* Fill out a varobj structure for the (root) variable being constructed. */ @@ -539,6 +536,9 @@ if (expression != NULL) { + struct frame_info *fi; + struct frame_info *old_fi = NULL; + struct block *block; char *p; enum varobj_languages lang; struct value *value = NULL;