From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28956 invoked by alias); 11 Aug 2010 13:23:46 -0000 Received: (qmail 28945 invoked by uid 22791); 11 Aug 2010 13:23:44 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Aug 2010 13:23:36 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7BDNZoA000673 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 11 Aug 2010 09:23:35 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7BDNWIO003314 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 11 Aug 2010 09:23:34 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o7BDNWsU007689 for ; Wed, 11 Aug 2010 15:23:32 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o7BDNWBa007688 for gdb-patches@sourceware.org; Wed, 11 Aug 2010 15:23:32 +0200 Date: Wed, 11 Aug 2010 13:23:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: Re: [patch] Code cleanup: Drop frame_unwind_find_by_frame retval Message-ID: <20100811132332.GA17230@host1.dyn.jankratochvil.net> References: <20100807195925.GA4025@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100807195925.GA4025@host1.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00144.txt.bz2 On Sat, 07 Aug 2010 21:59:26 +0200, Jan Kratochvil wrote: > it is obvious (as frame->unwind is already pre-set by > frame_prepare_for_sniffer). I will check it in in several days if not replied > otherwise. > > No regressions on {x86_64,x86_64-m32,i686}-fedora14snapshot-linux-gnu. > > 2010-08-07 Jan Kratochvil > > Code cleanup. > * frame-unwind.c (frame_unwind_find_by_frame): Remove the return type > and returned value. New comment from frame-unwind.h. > * frame-unwind.h (frame_unwind_find_by_frame): Remove the return type. > Extend the comment. > * frame.c (get_frame_id, frame_unwind_register_value) > (create_new_frame, get_prev_frame_1, frame_unwinder_is) > (get_frame_type, frame_unwind_arch): Do not use the return value of > frame_unwind_find_by_frame. Checked-in: http://sourceware.org/ml/gdb-cvs/2010-08/msg00052.html Thanks, Jan