From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29855 invoked by alias); 11 Aug 2010 13:25:02 -0000 Received: (qmail 29806 invoked by uid 22791); 11 Aug 2010 13:25:02 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Aug 2010 13:24:56 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7BDOtYO019989 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 11 Aug 2010 09:24:55 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7BDOqlj020984 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 11 Aug 2010 09:24:54 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o7BDOqeY008710 for ; Wed, 11 Aug 2010 15:24:52 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o7BDOqPT008709 for gdb-patches@sourceware.org; Wed, 11 Aug 2010 15:24:52 +0200 Date: Wed, 11 Aug 2010 13:25:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: Re: [patch] Code cleanup: unwinders: Reference directly the struct Message-ID: <20100811132452.GB17230@host1.dyn.jankratochvil.net> References: <20100808161300.GA768@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100808161300.GA768@host1.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00145.txt.bz2 On Sun, 08 Aug 2010 18:13:00 +0200, Jan Kratochvil wrote: > it is obvious, I am not aware why it has been made the current way. It even > does not make an ABI sense. If any ABI would make sense inside GDB sources, > which it does not. I will check it in in several days if not replied > otherwise. > > No regressions on {x86_64,x86_64-m32,i686}-fedora14snapshot-linux-gnu. > > 2010-08-08 Jan Kratochvil > > * dummy-frame.c (dummy_frame_unwinder): Remove its static qualifier. > Rename to dummy_frame_unwind. > (dummy_frame_unwind): Remove. > * dummy-frame.h (dummy_frame_unwind): Reference directly the struct. > * frame-unwind.c (frame_unwind_init): Use address of > dummy_frame_unwind and inline_frame_unwind. > * frame.c (create_sentinel_frame): Use address of > sentinel_frame_unwind. > * inline-frame.c (inline_frame_unwinder): Rename to > inline_frame_unwind. > (inline_frame_unwind): Remove. > * inline-frame.h (inline_frame_unwind): Reference directly the struct. > * sentinel-frame.c (sentinel_frame_unwinder): Rename to > sentinel_frame_unwind. > (sentinel_frame_unwind): Remove. > * sentinel-frame.h (sentinel_frame_unwind): Reference directly the > struct. Checked-in: http://sourceware.org/ml/gdb-cvs/2010-08/msg00053.html Thanks, Jan