From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: implement "watch -location"
Date: Fri, 13 Aug 2010 16:39:00 -0000 [thread overview]
Message-ID: <20100813163917.GA31498@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <m38w4c7qne.fsf@fleche.redhat.com>
Hi Tom,
this patch has a regression (guessing due to -lmcheck) on
{x86_64,x86_64-m32,i686}-fedora14snapshot-linux-gnu for:
PASS: gdb.base/default.exp: up-silently
-PASS: gdb.base/default.exp: watch
+ERROR: Process no longer exists
+UNRESOLVED: gdb.base/default.exp: watch
[...]
There are some freed VALUEs in use.
While thanks for this killer patch I do not like:
Num Type Disp Enb Address What
1 watchpoint keep y gdb_stdin
2 watchpoint keep y * (struct ui_file * *) 0x0000000001bf84d0
What does the watchpoint 2 watch? Is this add-on patch OK?
Num Type Disp Enb Address What
1 watchpoint keep y gdb_stdin
2 watchpoint keep y -location: gdb_stdin
Thanks,
Jan
gdb/
2010-08-13 Jan Kratochvil <jan.kratochvil@redhat.com>
* breakpoint.c (update_watchpoint): Add source empty line. Prefer
EXP_STRING_REPARSE to EXP_STRING.
(watch_command_1): Set also EXP_STRING_REPARSE.
(delete_breakpoint): Free also EXP_STRING_REPARSE.
* breakpoint.h (struct breakpoint): New field exp_string_reparse.
Update comment for exp_string.
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -1339,12 +1339,13 @@ update_watchpoint (struct breakpoint *b, int reparse)
if (within_current_scope && reparse)
{
char *s;
+
if (b->exp)
{
xfree (b->exp);
b->exp = NULL;
}
- s = b->exp_string;
+ s = b->exp_string_reparse ? b->exp_string_reparse : b->exp_string;
b->exp = parse_exp_1 (&s, b->exp_valid_block, 0);
/* If the meaning of expression itself changed, the old value is
no longer relevant. We don't want to report a watchpoint hit
@@ -8211,10 +8212,13 @@ watch_command_1 (char *arg, int accessflag, int from_tty, int just_location)
t = check_typedef (TYPE_TARGET_TYPE (check_typedef (t)));
name = type_to_string (t);
- b->exp_string = xstrprintf ("* (%s *) %s", name,
- core_addr_to_string (addr));
+ b->exp_string_reparse = xstrprintf ("* (%s *) %s", name,
+ core_addr_to_string (addr));
xfree (name);
+ b->exp_string = xstrprintf ("-location: %.*s",
+ (int) (exp_end - exp_start), exp_start);
+
/* The above expression is in C. */
b->language = language_c;
}
@@ -9644,6 +9648,7 @@ delete_breakpoint (struct breakpoint *bpt)
xfree (bpt->addr_string);
xfree (bpt->exp);
xfree (bpt->exp_string);
+ xfree (bpt->exp_string_reparse);
value_free (bpt->val);
xfree (bpt->source_file);
xfree (bpt->exec_pathname);
--- a/gdb/breakpoint.h
+++ b/gdb/breakpoint.h
@@ -450,8 +450,11 @@ struct breakpoint
/* String form of the breakpoint condition (malloc'd), or NULL if there
is no condition. */
char *cond_string;
- /* String form of exp (malloc'd), or NULL if none. */
+ /* String form of exp to use for displaying to the user (malloc'd), or
+ NULL if none. */
char *exp_string;
+ /* String form to use for reparsing of EXP (malloc'd) or NULL. */
+ char *exp_string_reparse;
/* The expression we are watching, or NULL if not a watchpoint. */
struct expression *exp;
next prev parent reply other threads:[~2010-08-13 16:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 22:04 Tom Tromey
2010-08-11 22:11 ` Michael Snyder
2010-08-11 22:15 ` Tom Tromey
2010-08-12 2:45 ` Hui Zhu
2010-08-12 7:55 ` André Pönitz
2010-08-12 3:07 ` Eli Zaretskii
2010-08-12 8:17 ` Phil Muldoon
2010-08-13 16:39 ` Jan Kratochvil [this message]
2010-08-13 18:27 ` Tom Tromey
2010-08-16 19:54 ` Jan Kratochvil
2010-08-13 18:25 ` Tom Tromey
2010-08-13 19:19 ` Eli Zaretskii
2010-08-13 21:21 ` Jan Kratochvil
2010-08-13 21:24 ` Tom Tromey
2010-08-16 18:13 ` Tom Tromey
2010-08-16 18:43 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100813163917.GA31498@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).