public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Chris Moller <cmoller@redhat.com>
Subject: Re: [patch] Fix crash on conditional watchpoints (PR 11371)
Date: Sun, 15 Aug 2010 12:08:00 -0000	[thread overview]
Message-ID: <20100815120352.GA31465@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <201008140338.17793.pedro@codesourcery.com>

On Sat, 14 Aug 2010 04:38:17 +0200, Pedro Alves wrote:
> Please give this alternative patch a try, and let me know what you think.

I find this patch as a better one.

(I could not (easily) regression it myself as sourceware.org is down today.)


> +/* Decrement reference count.  If the reference count reaches 0,
> +   destroy the bp_location.  Sets *BLP to NULL.  */
> +
> +static void
> +decref_bp_location (struct bp_location **blp)
> +{

I miss here some:
  gdb_assert ((*blp)->refc > 0);

> +  if (--(*blp)->refc == 0)
> +    free_bp_location (*blp);
> +  *blp = NULL;
> +}


Thanks,
Jan

  reply	other threads:[~2010-08-15 12:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-11 20:21 Jan Kratochvil
2010-08-14  2:38 ` Pedro Alves
2010-08-15 12:08   ` Jan Kratochvil [this message]
2010-08-17 21:14     ` Pedro Alves
2010-08-17 21:15       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100815120352.GA31465@host1.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=cmoller@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).