From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20975 invoked by alias); 17 Aug 2010 18:44:17 -0000 Received: (qmail 20966 invoked by uid 22791); 17 Aug 2010 18:44:17 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Aug 2010 18:44:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 48B942BABA9; Tue, 17 Aug 2010 14:44:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8nNlwMVkeqKp; Tue, 17 Aug 2010 14:44:11 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id DDC532BAB9B; Tue, 17 Aug 2010 14:44:10 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4071CF58F9; Tue, 17 Aug 2010 11:44:07 -0700 (PDT) Date: Tue, 17 Aug 2010 18:44:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Kazu Hirata , gdb-patches@sourceware.org Subject: Re: Your INTERMEDIATE_ENCODING patch for Solaris Message-ID: <20100817184407.GC3599@adacore.com> References: <20100731162500.32FAE5664F4@henry1.codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00267.txt.bz2 > Here is what I am testing. If someone can try it out on Solaris, I > would appreciate that. > > Tom > > b/gdb/ChangeLog: > 2010-08-17 Tom Tromey > > * gdb_wchar.h: Check HAVE_LIBICONV, __STDC_ISO_10646__. Change > how INTERMEDIATE_ENCODING is defined. > * configure, config.in: Rebuild. > * acinclude.m4 (AM_ICONV): Define HAVE_LIBICONV. What type of testing do you need? (I assume you need GDB to be built without GNU libiconv?) Run the testsuite before and after patch? Or something a little more specialized? -- Joel