From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23933 invoked by alias); 19 Aug 2010 10:01:30 -0000 Received: (qmail 23878 invoked by uid 22791); 19 Aug 2010 10:01:30 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Aug 2010 10:01:25 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 63D7E2BAC6F for ; Thu, 19 Aug 2010 06:01:23 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IYU3TjwneCJU for ; Thu, 19 Aug 2010 06:01:23 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3469E2BAC6D for ; Thu, 19 Aug 2010 06:01:23 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 5C124F59B2; Thu, 19 Aug 2010 12:01:21 +0200 (CEST) Date: Thu, 19 Aug 2010 10:01:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix regression in -file-list-exec-source-files command. Message-ID: <20100819100121.GA32167@adacore.com> References: <1282209516-3612-1-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1282209516-3612-1-git-send-email-brobecker@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00335.txt.bz2 > This was tested on x86_64-linux in HEAD. I'll see whether it's possible > to create a regression test or not, next. The problem that I am seeing is that, in the testsuite, we compile the examples using the source full filenames. For instance, using gdb.base/arrayidx.exp, we do: % gcc /[...]/gdb.base/arrayidx.c -g -lm -o [...] As a result, the filename field ends up containing the fullname: (gdb) interpreter-exec mi -file-list-exec-source-files ^done,files=[{file="/[...]/gdb.base/arrayidx.c",fullname="/[...]/gdb.base/arrayidx.c"}, [...] Because of that, we cannot use one of our source files to demonstrate the problem. The only thing I can think of that we could use to demonstrate the problem is to check for empty filenames. Before the patch was applied, one of the entries looked like this: {file="",fullname="init.c"} There is no guaranty that this is going to happen on all platforms, or even appear consistently on a given platform. This is probably dependent on the compiler as well as the way system libraries such as the C library have been built. But I suppose that is better than nothing. -- Joel