From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Andreas Schwab <schwab@redhat.com>, gdb-patches@sourceware.org
Subject: [patch] Fix new FAIL `reject p 0x1.1' [fixup] [Re: [patch] Handle 0 result from sscanf when parsing fp values.]
Date: Fri, 20 Aug 2010 07:37:00 -0000 [thread overview]
Message-ID: <20100820073703.GA19257@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <20100820073430.GA28054@host1.dyn.jankratochvil.net>
[fixup]
On Fri, 20 Aug 2010 09:34:30 +0200, Jan Kratochvil wrote:
Hi,
0x1.1 is a perfectly valid hexadecimal floating point. The new testcase:
PASS CentOS-4.8 glibc-2.3.4-2.43.el4_8.3
FAIL CentOS-5.5 glibc-2.5-49.el5_5.4
FAIL Fedora 13+14
OK to check-in?
Thanks,
Jan
gdb/testsuite/
2010-08-20 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.base/printcmds.exp (p 0x1.1): PASS on parse as 1.0625.
* gdb.java/jv-print.exp (p 0x1.1): PASS on parse as 1.0625.
--- a/gdb/testsuite/gdb.base/printcmds.exp
+++ b/gdb/testsuite/gdb.base/printcmds.exp
@@ -140,7 +140,8 @@ proc test_float_rejected {} {
test_print_reject "p 123foobar.bazfoo3"
test_print_reject "p 123EEEEEEEEEEEEEEEEE33333k333"
- test_print_reject "p 0x1.1"
+ # Older glibc does not support hex float, newer does.
+ test_print_reject "p 0x1.1" " = 1\\.0625\r\n"
# Test bad suffixes.
test_print_reject "p 1.1x"
--- a/gdb/testsuite/gdb.java/jv-print.exp
+++ b/gdb/testsuite/gdb.java/jv-print.exp
@@ -112,7 +112,8 @@ proc test_float_accepted {} {
proc test_float_rejected {} {
# Test invalid fp values.
- test_print_reject "p 0x1.1"
+ # Older glibc does not support hex float, newer does.
+ test_print_reject "p 0x1.1" " = 1\\.0625\r\n"
# Test bad suffixes.
test_print_reject "p 1.1x"
next prev parent reply other threads:[~2010-08-20 7:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 0:31 [patch] Handle 0 result from sscanf when parsing fp values Doug Evans
2010-08-17 8:18 ` Andreas Schwab
2010-08-17 11:37 ` Doug Evans
2010-08-18 20:38 ` Doug Evans
2010-08-20 7:34 ` [patch] Fix new FAIL `reject p 0x1.1' [Re: [patch] Handle 0 result from sscanf when parsing fp values.] Jan Kratochvil
2010-08-20 7:37 ` Jan Kratochvil [this message]
2010-08-20 11:58 ` [patch] Fix new FAIL `reject p 0x1.1' [fixup] " Joseph S. Myers
2010-08-23 15:35 ` Doug Evans
2010-08-23 18:55 ` [patch] Fix new FAIL `reject p 0x1.1' [fixup] Jan Kratochvil
2010-08-23 19:49 ` Doug Evans
2010-08-23 19:57 ` Doug Evans
2010-08-31 19:38 ` Jan Kratochvil
2010-08-31 22:51 ` Doug Evans
2010-09-02 15:11 ` Jan Kratochvil
2010-09-06 22:29 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820073703.GA19257@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).