From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31821 invoked by alias); 20 Aug 2010 07:37:25 -0000 Received: (qmail 31812 invoked by uid 22791); 20 Aug 2010 07:37:24 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Aug 2010 07:37:07 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7K7b67x030453 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 20 Aug 2010 03:37:06 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7K7b3sJ001942 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 20 Aug 2010 03:37:05 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o7K7b31v019274; Fri, 20 Aug 2010 09:37:03 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o7K7b3oW019273; Fri, 20 Aug 2010 09:37:03 +0200 Date: Fri, 20 Aug 2010 07:37:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: Andreas Schwab , gdb-patches@sourceware.org Subject: [patch] Fix new FAIL `reject p 0x1.1' [fixup] [Re: [patch] Handle 0 result from sscanf when parsing fp values.] Message-ID: <20100820073703.GA19257@host1.dyn.jankratochvil.net> References: <20100817003114.087EA84B8F@ruffy.mtv.corp.google.com> <20100820073430.GA28054@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100820073430.GA28054@host1.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00363.txt.bz2 [fixup] On Fri, 20 Aug 2010 09:34:30 +0200, Jan Kratochvil wrote: Hi, 0x1.1 is a perfectly valid hexadecimal floating point. The new testcase: PASS CentOS-4.8 glibc-2.3.4-2.43.el4_8.3 FAIL CentOS-5.5 glibc-2.5-49.el5_5.4 FAIL Fedora 13+14 OK to check-in? Thanks, Jan gdb/testsuite/ 2010-08-20 Jan Kratochvil * gdb.base/printcmds.exp (p 0x1.1): PASS on parse as 1.0625. * gdb.java/jv-print.exp (p 0x1.1): PASS on parse as 1.0625. --- a/gdb/testsuite/gdb.base/printcmds.exp +++ b/gdb/testsuite/gdb.base/printcmds.exp @@ -140,7 +140,8 @@ proc test_float_rejected {} { test_print_reject "p 123foobar.bazfoo3" test_print_reject "p 123EEEEEEEEEEEEEEEEE33333k333" - test_print_reject "p 0x1.1" + # Older glibc does not support hex float, newer does. + test_print_reject "p 0x1.1" " = 1\\.0625\r\n" # Test bad suffixes. test_print_reject "p 1.1x" --- a/gdb/testsuite/gdb.java/jv-print.exp +++ b/gdb/testsuite/gdb.java/jv-print.exp @@ -112,7 +112,8 @@ proc test_float_accepted {} { proc test_float_rejected {} { # Test invalid fp values. - test_print_reject "p 0x1.1" + # Older glibc does not support hex float, newer does. + test_print_reject "p 0x1.1" " = 1\\.0625\r\n" # Test bad suffixes. test_print_reject "p 1.1x"