From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7519 invoked by alias); 28 Aug 2010 08:38:59 -0000 Received: (qmail 7506 invoked by uid 22791); 28 Aug 2010 08:38:57 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Aug 2010 08:38:53 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7S8cpTR008736 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 28 Aug 2010 04:38:51 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7S8cnxv006737 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 28 Aug 2010 04:38:51 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o7S8cn3d027580 for ; Sat, 28 Aug 2010 10:38:49 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o7S8cm85027579 for gdb-patches@sourceware.org; Sat, 28 Aug 2010 10:38:48 +0200 Date: Sat, 28 Aug 2010 08:38:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: Re: [patch] Code cleanup: int *status -> int *statusp Message-ID: <20100828083848.GA26180@host1.dyn.jankratochvil.net> References: <20100826095536.GA8857@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100826095536.GA8857@host1.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00477.txt.bz2 Hi, checked-in. Jan http://sourceware.org/ml/gdb-cvs/2010-08/msg00182.html --- src/gdb/ChangeLog 2010/08/27 23:09:58 1.12123 +++ src/gdb/ChangeLog 2010/08/28 08:38:24 1.12124 @@ -1,3 +1,9 @@ +2010-08-28 Jan Kratochvil + + Code cleanup. + * linux-nat.c (pull_pid_from_list): Rename status to statusp. + (my_waitpid): Likewise. + 2010-08-27 Doug Evans * dwarf2read.c (dw2_require_line_header): Read from .debug_types --- src/gdb/linux-nat.c 2010/07/27 21:22:09 1.180 +++ src/gdb/linux-nat.c 2010/08/28 08:38:25 1.181 @@ -376,7 +376,7 @@ } static int -pull_pid_from_list (struct simple_pid_list **listp, int pid, int *status) +pull_pid_from_list (struct simple_pid_list **listp, int pid, int *statusp) { struct simple_pid_list **p; @@ -385,7 +385,7 @@ { struct simple_pid_list *next = (*p)->next; - *status = (*p)->status; + *statusp = (*p)->status; xfree (*p); *p = next; return 1; @@ -414,13 +414,13 @@ /* Wrapper function for waitpid which handles EINTR. */ static int -my_waitpid (int pid, int *status, int flags) +my_waitpid (int pid, int *statusp, int flags) { int ret; do { - ret = waitpid (pid, status, flags); + ret = waitpid (pid, statusp, flags); } while (ret == -1 && errno == EINTR);