From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9017 invoked by alias); 30 Aug 2010 08:14:37 -0000 Received: (qmail 9003 invoked by uid 22791); 30 Aug 2010 08:14:35 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Aug 2010 08:14:30 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o7U8EEdA009238; Mon, 30 Aug 2010 10:14:14 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o7U8ECNZ009010; Mon, 30 Aug 2010 10:14:12 +0200 (CEST) Date: Mon, 30 Aug 2010 08:14:00 -0000 Message-Id: <201008300814.o7U8ECNZ009010@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: jan.kratochvil@redhat.com CC: gdb-patches@sourceware.org In-reply-to: <20100830071040.GB6831@host1.dyn.jankratochvil.net> (message from Jan Kratochvil on Mon, 30 Aug 2010 09:10:40 +0200) Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t References: <20100830071040.GB6831@host1.dyn.jankratochvil.net> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00496.txt.bz2 > Date: Mon, 30 Aug 2010 09:10:40 +0200 > From: Jan Kratochvil > > series #2 of: http://sourceware.org/ml/gdb-patches/2010-07/msg00408.html > > Hi, > > there is no compiled code change in this patch. This patch just renames `enum > target_signal' to target_signal_t (typedef) so the code is more flexible for > the later changes. No other change is made. The _t suffix is actually reserved by POSIX, so using it is actually a bad idea. Perhaps change it to gdb_target_signal, or just target_signal (making it a typedef for an anonymous enum)?