From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13118 invoked by alias); 30 Aug 2010 08:24:16 -0000 Received: (qmail 13105 invoked by uid 22791); 30 Aug 2010 08:24:15 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Aug 2010 08:24:11 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7U8O9RO020852 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 30 Aug 2010 04:24:10 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7U8O70j023735 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 30 Aug 2010 04:24:09 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o7U8O7Yj006990; Mon, 30 Aug 2010 10:24:07 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o7U8O73t006989; Mon, 30 Aug 2010 10:24:07 +0200 Date: Mon, 30 Aug 2010 08:24:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t Message-ID: <20100830082407.GA6881@host1.dyn.jankratochvil.net> References: <20100830071040.GB6831@host1.dyn.jankratochvil.net> <201008300814.o7U8ECNZ009010@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201008300814.o7U8ECNZ009010@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00497.txt.bz2 On Mon, 30 Aug 2010 10:14:12 +0200, Mark Kettenis wrote: > The _t suffix is actually reserved by POSIX, so using it is actually a > bad idea. Perhaps change it to gdb_target_signal, or just > target_signal (making it a typedef for an anonymous enum)? I see too many types in GDB and everywhere ending with _t (ptid_t for all). I do not mind at all about the type name but before reposting the patchset I would like agreement from one more global maintainer. Thanks, Jan