From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 5/9]#2 Move siginfo_fixup linux-nat -> inf-ptrace
Date: Mon, 30 Aug 2010 11:44:00 -0000 [thread overview]
Message-ID: <201008301144.o7UBiHr9023794@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20100830071312.GF6831@host1.dyn.jankratochvil.net> (message from Jan Kratochvil on Mon, 30 Aug 2010 09:13:12 +0200)
> Date: Mon, 30 Aug 2010 09:13:12 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Hi,
>
> as the siginfo biarch conversion needs to be done now even during inf-ptrace
> ptrace calls the interface had to be moved there. There are no code changes
> of it in this patch.
Couple of issues/questions:
* It's difficult to review this diff as is, since the part that
actually uses this stuff in the inf-ptrace.c file is missing. I may
be missing something, but my gut feeling is that the siginfo
processing is (at least for now) a Linux-specific feature and
therefore belongs in linux-nat.c.
Assuming that my gut feeling is wrong:
* Isn't it better to make the siginfo conversion/fixup part of the
target vector?
* The memcpy that's being done requires the size of "struct siginfo"
to be known. I'm not sure all platforms that use ptrace(2) actually
have a "struct siginfo" (OpenBSD, HP-UX 10.20 and Linux have it).
I'm not sure <signal.h> is enough to actually make the definition
available (have some doubts here for HP-UX 10.20).
* I'd like to see siginfo_fixup() renamed into inf_ptrace_siginfo_fixup(),
and made static if possible.
* All of this probably should be #ifdef PT_GETSIGINFO.
Cheers,
Mark
next prev parent reply other threads:[~2010-08-30 11:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 7:13 Jan Kratochvil
2010-08-30 11:44 ` Mark Kettenis [this message]
2010-08-31 18:16 ` cancel: " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008301144.o7UBiHr9023794@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).