From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch 2/9]#2 Split print_stop_reason into 5 funcs
Date: Mon, 30 Aug 2010 10:56:00 -0000 [thread overview]
Message-ID: <201008301156.43103.pedro@codesourcery.com> (raw)
In-Reply-To: <20100830071118.GC6831@host1.dyn.jankratochvil.net>
On Monday 30 August 2010 08:11:18, Jan Kratochvil wrote:
> applicable independently.
Agreed. This is okay.
> -/* Print why the inferior has stopped. We always print something when
> - the inferior exits, or receives a signal. The rest of the cases are
> - dealt with later on in normal_stop() and print_it_typical(). Ideally
> - there should be a call to this function from handle_inferior_event()
> - each time stop_stepping() is called.*/
> +/* Several print_*_reason functions to print why the inferior has stopped.
> + We always print something when the inferior exits, or receives a signal.
> + The rest of the cases are dealt with later on in normal_stop() and
> + print_it_typical(). Ideally there should be a call to this function from
^^^^^^^^^^^^^^^^^^^^^
needs adjustment
> + handle_inferior_event() each time stop_stepping() is called.*/
Might as well fix the missing spaces ---------------------------^
[I'd take the opportunity to remove the '()'s above as well.]
--
Pedro Alves
next prev parent reply other threads:[~2010-08-30 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 7:11 Jan Kratochvil
2010-08-30 10:56 ` Pedro Alves [this message]
2010-09-04 21:58 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201008301156.43103.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).