From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3403 invoked by alias); 30 Aug 2010 10:56:54 -0000 Received: (qmail 3395 invoked by uid 22791); 30 Aug 2010 10:56:53 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Aug 2010 10:56:48 +0000 Received: (qmail 25510 invoked from network); 30 Aug 2010 10:56:45 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Aug 2010 10:56:45 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch 2/9]#2 Split print_stop_reason into 5 funcs Date: Mon, 30 Aug 2010 10:56:00 -0000 User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; ) Cc: Jan Kratochvil References: <20100830071118.GC6831@host1.dyn.jankratochvil.net> In-Reply-To: <20100830071118.GC6831@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201008301156.43103.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00504.txt.bz2 On Monday 30 August 2010 08:11:18, Jan Kratochvil wrote: > applicable independently. Agreed. This is okay. > -/* Print why the inferior has stopped. We always print something when > - the inferior exits, or receives a signal. The rest of the cases are > - dealt with later on in normal_stop() and print_it_typical(). Ideally > - there should be a call to this function from handle_inferior_event() > - each time stop_stepping() is called.*/ > +/* Several print_*_reason functions to print why the inferior has stopped. > + We always print something when the inferior exits, or receives a signal. > + The rest of the cases are dealt with later on in normal_stop() and > + print_it_typical(). Ideally there should be a call to this function from ^^^^^^^^^^^^^^^^^^^^^ needs adjustment > + handle_inferior_event() each time stop_stepping() is called.*/ Might as well fix the missing spaces ---------------------------^ [I'd take the opportunity to remove the '()'s above as well.] -- Pedro Alves