From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>, Eli Zaretskii <eliz@gnu.org>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
Date: Tue, 31 Aug 2010 18:28:00 -0000 [thread overview]
Message-ID: <20100831182829.GA16136@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <E1Oq55N-0006ia-B0@fencepost.gnu.org> <20100830140814.GE2986@adacore.com>
On Mon, 30 Aug 2010 16:08:14 +0200, Joel Brobecker wrote:
> It does not matter much to me if we decide to allow types named with
> a _t suffix. But the gdb_ prefix also increases the chances of avoiding
> name collisions with external declarations.
On Mon, 30 Aug 2010 16:11:45 +0200, Eli Zaretskii wrote:
> A strange ruling, I think _t is used in lots of applications.
I would prefer gdb_target_signal_t or also gdb_target_signal.
Is one of those approved?
Now I probably won't extend target_signal by any new fields (as the logic can
be kept inside linux-nat.c) so this part remains only as a "code cleanup" to
better sanity check the types compatibility (by the struct wrapping). There
have been caught several minor bugs already before and in this patchset.
Thanks,
Jan
next prev parent reply other threads:[~2010-08-31 18:28 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 7:11 Jan Kratochvil
2010-08-30 8:14 ` Mark Kettenis
2010-08-30 8:24 ` Jan Kratochvil
2010-08-30 10:09 ` Eli Zaretskii
2010-08-30 11:11 ` Mark Kettenis
2010-08-30 14:08 ` Joel Brobecker
2010-08-31 18:28 ` Jan Kratochvil [this message]
2010-08-31 18:45 ` Mark Kettenis
2010-09-01 2:03 ` Joel Brobecker
2010-09-01 18:18 ` Joel Brobecker
2010-09-01 18:30 ` Jan Kratochvil
2010-09-01 18:38 ` Pedro Alves
2010-09-01 18:45 ` Jan Kratochvil
2010-09-01 18:40 ` Joel Brobecker
2010-09-01 18:51 ` Jan Kratochvil
2010-09-01 19:08 ` Pedro Alves
2010-09-01 19:28 ` Jan Kratochvil
2010-09-01 20:06 ` Pedro Alves
2010-09-01 20:06 ` Daniel Jacobowitz
2010-09-01 20:10 ` Pedro Alves
2010-09-02 9:46 ` Pedro Alves
2010-09-02 14:01 ` Jan Kratochvil
2010-09-02 15:36 ` Joel Brobecker
2010-09-02 19:02 ` Pedro Alves
2010-09-02 20:46 ` Jan Kratochvil
2010-09-07 18:59 ` Jan Kratochvil
2010-09-02 16:02 ` Joel Brobecker
2010-09-02 17:04 ` Jan Kratochvil
2010-09-06 0:29 ` Jan Kratochvil
2010-09-06 13:30 ` Pedro Alves
2010-09-06 14:52 ` Jan Kratochvil
2010-09-08 23:42 ` Jan Kratochvil
2010-09-01 20:23 ` Jan Kratochvil
2010-09-01 20:30 ` Mark Kettenis
2010-09-01 20:47 ` Pedro Alves
2010-09-01 21:32 ` Joseph S. Myers
2010-09-01 19:12 ` Joel Brobecker
2010-09-01 22:37 ` Tom Tromey
2010-08-30 14:11 ` Eli Zaretskii
2010-08-30 17:34 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100831182829.GA16136@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).