From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20150 invoked by alias); 31 Aug 2010 18:28:52 -0000 Received: (qmail 20142 invoked by uid 22791); 31 Aug 2010 18:28:51 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,FAKE_REPLY_C,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 18:28:48 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7VISXpK018029 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 31 Aug 2010 14:28:33 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7VISVKb008406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 31 Aug 2010 14:28:32 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o7VISU2Y016462; Tue, 31 Aug 2010 20:28:30 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o7VISTe9016461; Tue, 31 Aug 2010 20:28:29 +0200 Date: Tue, 31 Aug 2010 18:28:00 -0000 From: Jan Kratochvil To: Joel Brobecker , Eli Zaretskii Cc: Mark Kettenis , gdb-patches@sourceware.org Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t Message-ID: <20100831182829.GA16136@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100830140814.GE2986@adacore.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00561.txt.bz2 On Mon, 30 Aug 2010 16:08:14 +0200, Joel Brobecker wrote: > It does not matter much to me if we decide to allow types named with > a _t suffix. But the gdb_ prefix also increases the chances of avoiding > name collisions with external declarations. On Mon, 30 Aug 2010 16:11:45 +0200, Eli Zaretskii wrote: > A strange ruling, I think _t is used in lots of applications. I would prefer gdb_target_signal_t or also gdb_target_signal. Is one of those approved? Now I probably won't extend target_signal by any new fields (as the logic can be kept inside linux-nat.c) so this part remains only as a "code cleanup" to better sanity check the types compatibility (by the struct wrapping). There have been caught several minor bugs already before and in this patchset. Thanks, Jan