From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8082 invoked by alias); 31 Aug 2010 19:38:08 -0000 Received: (qmail 8073 invoked by uid 22791); 31 Aug 2010 19:38:07 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_40,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 19:38:02 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7VJbra0027927 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 31 Aug 2010 15:37:53 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7VJbpOR032606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 31 Aug 2010 15:37:53 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o7VJbpjh023199; Tue, 31 Aug 2010 21:37:51 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o7VJboKU023198; Tue, 31 Aug 2010 21:37:50 +0200 Date: Tue, 31 Aug 2010 19:38:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: "Joseph S. Myers" , Andreas Schwab , gdb-patches@sourceware.org Subject: Re: [patch] Fix new FAIL `reject p 0x1.1' [fixup] Message-ID: <20100831193749.GA18505@host1.dyn.jankratochvil.net> References: <20100820073430.GA28054@host1.dyn.jankratochvil.net> <20100820073703.GA19257@host1.dyn.jankratochvil.net> <20100823185451.GA3512@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00570.txt.bz2 On Mon, 23 Aug 2010 21:57:19 +0200, Doug Evans wrote: > On Mon, Aug 23, 2010 at 12:49 PM, Doug Evans wrote: > >> While thanks for catching it I still believe now my testcase update is the > >> appropriate fix - if glibc supports then extended input syntax let the GDB > >> user benefit from it. > > > > It's ok with me. > > I should add that IWBN to have an additional testcase that exercises > sscanf (...) == 0 on newer glibcs. OK, I forgot first. OK to check-in? Tested both cases (RHEL-4.8 and Fedora14snapshot). Thanks, Jan gdb/testsuite/ 2010-08-31 Jan Kratochvil * gdb.base/printcmds.exp (test_float_accepted): Import gdb_prompt. Move here, negate and extend by XFAIL the "p 0x1.1" test from ... (test_float_rejected): ... here. * gdb.java/jv-print.exp (test_float_accepted): Import gdb_prompt. Move here, negate and extend by XFAIL the "p 0x1.1" test from ... (test_float_rejected): ... here. --- a/gdb/testsuite/gdb.base/printcmds.exp +++ b/gdb/testsuite/gdb.base/printcmds.exp @@ -119,6 +119,8 @@ proc test_integer_literals_rejected {} { } proc test_float_accepted {} { + global gdb_prompt + # This test is useful to catch successful parsing of the first fp value. gdb_test "p 123.4+56.7" " = 180.(099\[0-9]*|100\[0-9\]*)" "check for floating addition" @@ -129,6 +131,18 @@ proc test_float_accepted {} { gdb_test "p 1.5f" " = 1.5" gdb_test "p 1.l" " = 1" gdb_test "p 1.5l" " = 1.5" + + # Test hexadecimal floating point. + set test "p 0x1.1" + gdb_test_multiple $test $test { + -re " = 1\\.0625\r\n$gdb_prompt $" { + pass $test + } + -re "Invalid number \"0x1\\.1\"\\.\r\n$gdb_prompt $" { + # Older glibc does not support hex float, newer does. + xfail $test + } + } } proc test_float_rejected {} { @@ -140,7 +154,6 @@ proc test_float_rejected {} { test_print_reject "p 123foobar.bazfoo3" test_print_reject "p 123EEEEEEEEEEEEEEEEE33333k333" - test_print_reject "p 0x1.1" # Test bad suffixes. test_print_reject "p 1.1x" --- a/gdb/testsuite/gdb.java/jv-print.exp +++ b/gdb/testsuite/gdb.java/jv-print.exp @@ -98,6 +98,8 @@ proc test_integer_literals_rejected {} { } proc test_float_accepted {} { + global gdb_prompt + # Test parsing of fp value with legit text following. gdb_test "p 1234.5+1" " = 1235.5" "check fp + text" @@ -108,12 +110,21 @@ proc test_float_accepted {} { gdb_test "p 1.5f" " = 1.5" gdb_test "p 1.d" " = 1" gdb_test "p 1.5d" " = 1.5" + + # Test hexadecimal floating point. + set test "p 0x1.1" + gdb_test_multiple $test $test { + -re " = 1\\.0625\r\n$gdb_prompt $" { + pass $test + } + -re "Invalid number \"0x1\\.1\"\r\n$gdb_prompt $" { + # Older glibc does not support hex float, newer does. + xfail $test + } + } } proc test_float_rejected {} { - # Test invalid fp values. - test_print_reject "p 0x1.1" - # Test bad suffixes. test_print_reject "p 1.1x" test_print_reject "p 1.1ff"