From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75291-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16997 invoked by alias); 31 Aug 2010 19:55:48 -0000
Received: (qmail 16987 invoked by uid 22791); 31 Aug 2010 19:55:48 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 19:55:44 +0000
Received: (qmail 26943 invoked from network); 31 Aug 2010 19:55:42 -0000
Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 31 Aug 2010 19:55:42 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] include alloca.h if available.
Date: Tue, 31 Aug 2010 19:55:00 -0000
User-Agent: KMail/1.13.2 (Linux/2.6.33-29-realtime; KDE/4.4.2; x86_64; ; )
Cc: Joel Brobecker <brobecker@adacore.com>
References: <1283281511-30193-1-git-send-email-brobecker@adacore.com>
In-Reply-To: <1283281511-30193-1-git-send-email-brobecker@adacore.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201008312055.40504.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-08/txt/msg00573.txt.bz2

On Tuesday 31 August 2010 20:05:11, Joel Brobecker wrote:
> On LynxOS, alloca is defined in allocal.h.  This fixes one warning that
> occurs when building GDBserver for LynxOS.

No objections here.  One note.

> gdb/gdbserver/ChangeLog:
> 
>         * configure.ac: Add configure check for alloca.
>         * configure, config.in: Regenerate.

>         * server.h: Include alloca.h if it exists.

Every include of malloc.h in gdbserver's common code:

$ grep malloc\\.h *.c
gdbreplay.c:#include <malloc.h>
mem-break.c:#include <malloc.h>
server.c:#include <malloc.h>
tracepoint.c:#include <malloc.h>
utils.c:#include <malloc.h>
win32-low.c:#include <malloc.h>

is there for alloca on mingw32.  It might have made
sense to keep those together.  I don't really care that
much either way, just pointing it out.  :-)

-- 
Pedro Alves